508823 - template_inner should not have to be reset after calling it with a language-specific variable

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement, P1)

Description

[Max Kanat-Alexander]

Right now after we do Bugzilla->template_inner($lang) we have to do Bugzilla->template_inner("") later. We should not have to do this.

Comment 1

[Max Kanat-Alexander]

Attachment: Untested WIP Patch

Here's what I have so far. I suspect I will still have to deal with the times when things like get_text are called from inside a non-English template.

Comment 2

[Frédéric Buclin]

We no longer accept new features for Bugzilla 3.6. Retargetting to 3.8.

Comment 3

[Max Kanat-Alexander]

Attachment: v1

I believe that this depends on the blocker, but it may not, actually.

Comment 4

[Frédéric Buclin]

Comment on attachment 426130 [details] [diff] [review]
v1

bitrotten

Comment 5

[Max Kanat-Alexander]

Attachment: v2

Okay, fixed the bitrot.

Comment 6

[Frédéric Buclin]

Comment on attachment 429444 [details] [diff] [review]
v2

Seems to work fine. r=LpSolit

Comment 7

[Max Kanat-Alexander]

relnote as a change that extension authors and customizers might want to know about.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla.pm
modified relogin.cgi
modified whine.pl
modified whineatnews.pl
modified Bugzilla/BugMail.pm
modified Bugzilla/Flag.pm
modified Bugzilla/Template.pm
modified Bugzilla/Token.pm
modified Bugzilla/Template/Plugin/Hook.pm
modified extensions/Voting/Extension.pm
Committed revision 7038.

Comment 8

[Max Kanat-Alexander]

Added to the release notes in bug 604256.