545235 - Simplify Bugzilla's language-choosing code

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

Right now the code that picks a language is in Bugzilla->languages, include_languages, Bugzilla->request_cache->{language}, the "current_language" template function, and maybe even a few other places.

In general it should be very much simplified, which will also allow me to do other things that I want to do.

Comment 1

[Max Kanat-Alexander]

Here's all we actually need to know:

1. What are all the available languages that Bugzilla has installed?
2. What are the languages that the user wants to see Bugzilla in, in priority order?

Then from that, we determine:

* What is the search order that we should be using for templates, in terms of languages?
* What documentation should we be displaying for help links?

And there is also the special case of sending emails in a specific language to a user, when that language differs from the language of the currently-logged-in user.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Okay, here we go. This is mostly just a code cleanup, but it does eliminate the need for the "use_languages" parameter.

We no longer need to cache include_languages because we cache supported_languages instead and I don't see any slowdown by calling include_languages multiple times.

Comment 3

[Frédéric Buclin]

Comment on attachment 426103 [details] [diff] [review]
v1

Seems to work fine. r=LpSolit

Comment 4

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla.pm
modified Bugzilla/Template.pm
modified Bugzilla/Install/Util.pm
modified Bugzilla/Template/Plugin/Hook.pm
Committed revision 7034.