508988 - Validator: source links don't work if source viewing is not enabled

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Dave Garrett]

If the validator spits out a message about a line of source it notes the file and line number and links this to the appropriate file in the source via the online viewer. If the add-on doesn't have this viewer enabled this doesn't work and you just get "This add-on is not viewable here.".

Two possible solutions:
1) Let the developer use this even if it's disabled for the general public.
2) The lazy route: Just don't link there if it's disabled.

Comment 1

[Wil Clouser [:clouserw]]

Hmm, good call.  We should allow the developer, editors, and admins to view the source regardless of that flag.

Comment 2

[RJ Walsh [:rjwalsh]]

Attachment: Allow developers to view their own source, even if the feature is disabled

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 393286 [details] [diff] [review]
Allow developers to view their own source, even if the feature is disabled

It would be nice to see the block of code to check of a user is a developer of an add-on as a function.

Also, adding a test for this would help prevent it regressing.

Comment 4

[RJ Walsh [:rjwalsh]]

Fixed in  (unit tests are in views/files/browse.test.php)

Comment 5

[RJ Walsh [:rjwalsh]]

Augh, no revision.  Fixed in r49016

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/developers/versions/validate/40468.