509039 - tweak install.js test for seamonkey

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Wil Clouser [:clouserw]]

From the blog:

And I saw that you choke on missing install.js for SeaMonkey compatibility on dictionaries, which is nice for MySpell dictionaries, but for HunSpell it’s wrong, as we only support those in 2.x and even SeaMonkey doesn’t need/want install.js there. So, if minVersion for SeaMonkey is 2.0a1 or higher, please omit this check for install.js

Comment 1

[RJ Walsh [:rjwalsh]]

Attachment: Skips the test if minversion >= 2.0a1

Comment 2

[Wil Clouser [:clouserw]]

Comment on attachment 393229 [details] [diff] [review]
Skips the test if minversion >= 2.0a1

since compareVersions() returns multiple non-boolean values I'd like to see a specific comparison in the if() for what it's returning.

Comment 3

[RJ Walsh [:rjwalsh]]

Fixed in r48793

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Kairo: would you mind taking verification of this on preview?  Thanks!

Comment 5

[Robert Kaiser]

As I feared, we got it slightly wrong. We need 2.0a1pre or higher.

I now have a variant of the 2.0 version of addon ID 70544 up on preview, that one can be used for testing this.

Comment 6

[RJ Walsh [:rjwalsh]]

Attachment: Fix to use 2.0a1pre

Comment 7

[RJ Walsh [:rjwalsh]]

Fixed in r48919

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Mind taking a fresh look at this, Robert?  Thanks!

Comment 9

[Robert Kaiser]

(In reply to comment #5)
> As I feared, we got it slightly wrong. We need 2.0a1pre or higher.
> 
> I now have a variant of the 2.0 version of addon ID 70544 up on preview, that
> one can be used for testing this.

oops, add-on ID is 3077, the version ID is 70544. In any case, https://preview.addons.mozilla.org/en-US/developers/versions/validate/70544 now validates, so this is corrected. Thanks for that!