50910 - auto-complete in browser and message compose causes hang

Status: VERIFIED FIXED

(Core Graveyard :: GFX, defect, P3)

Description

[Tracy Walker [:tracy]]

commmercial builds:

Windows 2000-08-31-06-M18
Linux 2000-08-31-06-M18
Mac 2000-08-31-04-M18

opening a new message window then typing the addressee into the to field causes 
freeze.  on linux it would alwasy freeze on attempt to type "@" symbol.  other 
platforms would freeze when attempting to prefill matched addressee

Comment 1

[Daniel (Leaf) Nunes]

this happens in mozilla pure builds, as well. I don't think this is in mailnews
alone, because autocomplete in the url is causing a hang as well.

Is autocomplete used for both urls and addresses? changing product to browser,
will change component when bugzilla realizes i want to look at the new product.

Comment 2

[Daniel (Leaf) Nunes]

updating summary.

Comment 3

[Suresh]

If it is only the autocomplete that is causing the hang, one workaround would be 
to turn off the autocomplete pref (atleast for mail compose) and see if this 
would help.

Comment 4

[lchiang]

I believe both autocomplete for URL and addresses are the same code?

Comment 5

[David :Bienvenu]

I've also found that reply sometimes hangs. It's hanging in the string classes, 
with this call on the stack:

    mBuffer->Append(mSpace + mValue + mEqual + mQuote + *str + mQuote);

in nsXIFConverter::AppendEntity.

I don't know if it's the same problem, but it's a strong possibility.

Comment 6

[David :Bienvenu]

Yep, it's the same hang: here's the stack trace:

NTDLL! 77f76274()
nsDebug::Assertion(const char * 0x100c4630 
??_C@_0CD@LMHB@?$HMcopy_string?$HM?5will?5never?5termina@, const char * 
0x100c465c ??_C@_0BB@HMLA@count_copied?5?$DO?50?$AA@, const char * 0x100c4670 
??_C@_0CB@FPEE@?4?4?2?4?4?2dist?2include?2nsAlgorithm?4h@, int 0x00000049) line 
253 + 13 bytes
copy_string(nsReadingIterator<unsigned short> {...}, nsReadingIterator<unsigned 
short> {...}, nsWritingIterator<unsigned short> {...}) line 73 + 28 bytes
basic_nsAWritableString<unsigned short>::do_AppendFromReadable(const 
basic_nsAReadableString<unsigned short> & {...}) line 583 + 98 bytes
basic_nsAWritableString<unsigned short>::AppendFromPromise(const 
basic_nsAReadableString<unsigned short> & {...}) line 563
basic_nsAWritableString<unsigned short>::Append(const nsPromiseReadable<unsigned 
short> & {...}) line 335 + 19 bytes
nsXIFConverter::AppendEntity(nsXIFConverter * const 0x04728180, const unsigned 
short 0x003c, basic_nsAWritableString<unsigned short> * 0x00000000, 
basic_nsAReadableString<unsigned short> * 0x0012c90c) line 378 + 140 bytes
nsXIFConverter::AddContent(nsXIFConverter * const 0x04728180, const 
basic_nsAReadableString<unsigned short> & {...}) line 404 + 29 bytes

Reassigning to scc.

Comment 7

[Daniel (Leaf) Nunes]

scc is checking in a fix as i write.

Comment 8

[R.K.Aa.]

i think these ones are dups - it's raining "freeze" bugs today:

bug 50912 Highlighting text causes hang. 
bug 50924 Trying to login to my.netscape.com page freezes the browser 
bug 50926 clicking on HTML source tab freezes
bug 50929 "localhost" doesn't work -- freeze when trying to use search
bug 50930 Mozilla.org page hangs composer

Comment 9

[Scott Collins]

I checked in what I believe is the fix ... xpcom/ds/nsAReadableString.h,1.72.  
It's a header, you'll need a full rebuild as ducurroz discovered :-)  I believe 
this fixes the bug (just a typo -- an omission from last nights Windows specific 
fix that now effects every platform); haven't yet seen any evidence that this 
_isn't_ the right fix.

All these hangs are related if they come from an '+' of 3 or more strings in a 
single expression somewhere in the callstack.

Comment 10

[Charles Manske]

*** Bug 50930 has been marked as a duplicate of this bug. ***

Comment 11

[Charles Manske]

*** Bug 50930 has been marked as a duplicate of this bug. ***

Comment 12

[Charles Manske]

*** Bug 50930 has been marked as a duplicate of this bug. ***

Comment 13

[Charles Manske]

*** Bug 50926 has been marked as a duplicate of this bug. ***

Comment 14

[R.K.Aa.]

*** Bug 50957 has been marked as a duplicate of this bug. ***

Comment 15

[leger]

Putting on [dogfood+] radar.

Comment 16

[David :Bienvenu]

this is fixed.

Comment 17

[Tracy Walker [:tracy]]

marking verified fixed

builds:
windows 2000-09-05-06-M18
linux 2000-09-05-06-M18
mac 2000-09-05-04-M18