509421 - TARGET_XPCOM_ABI not set when building on powerpc 64 (ppc64)

Status: RESOLVED DUPLICATE of bug 520224

(Firefox Build System :: General, defect)

Description

[Remi Collet]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; fr; rv:1.9.1.2) Gecko/20090803 Fedora/3.5.2-2.fc11 Firefox/3.5.2
Build Identifier: build from sources

This break the build of extension which rely on this information (enigmail p.e.)



Reproducible: Always




Simple patch proposal :

--- configure.in.ppc64	2009-07-21 14:01:25.000000000 +0200
+++ configure.in	2009-07-21 14:01:51.000000000 +0200
@@ -1451,7 +1451,7 @@
     CPU_ARCH=sparc
     ;;
 
-x86_64 | ia64)
+x86_64 | ia64 | ppc64)
     CPU_ARCH="$OS_TEST"
     ;;
 esac

Comment 1

[Remi Collet]

I forget to note : this concern build 3.0b3 from sources.

Comment 2

[Bill McGonigle (not currently reading bugmail; please contact directly)]

Confirming based on discussion of enigmail builds on fedora-devel list.

Comment 3

[Magnus Melin [:mkmelin]]

Remi: please attach the patch as a normal patch and ask review 
http://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree

Comment 4

[Remi Collet]

Attachment: patch to set CPU_ARCH on ppc64 [Superseded by bug 520224]

Need to build extension (enigmail) which rely on TARGET_XPCOM_ABI

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 394700 [details] [diff] [review]
patch to set CPU_ARCH on ppc64
[Superseded by bug 520224]

(I'm not a reviewer: forwarding to KaiRo.)

Don't m-1.9.1 and m-c need this too/first?
(At least to stay in sync.)

Comment 6

[Robert Kaiser]

Comment on attachment 394700 [details] [diff] [review]
patch to set CPU_ARCH on ppc64
[Superseded by bug 520224]

It doesn't make any sense to put this into comm-central before it is in both mozilla-central and mozilla-1.9.1, please request it to go there first and once it landed there, re-request my review for this.

Comment 7

[Justin Wood (:Callek)]

Remi, do you plan to, or did you do a mozilla-central patch for this?

What is the status here?

Comment 8

[Justin Wood (:Callek)]

reset assignee to default per no response from c#7, and moved to Core as c-c won't want it before m-c gets it.

Comment 9

[Remi Collet]

Sorry for the no-response.

This bug can be closed as ppc64 is now handle correctly by latest mozilla configure.