520224 - fix TARGET_XPCOM_ABI for ppc64 and s390(x)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

Report from Novell:

TARGET_XPCOM_ABI makes no difference between 32 and 64bit ppc architecture and doesn't recognize s390 and s390x at all.
I don't have access to that type of machines but got a proposed patch from Novell.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch

Patch as I got it from [e-mail]

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 404296 [details] [diff] [review]
patch

The patch looks ok to me, with one nit:
 powerpc* | ppc | rs6000)

You should probably drop the wildcard here, since you're handling powerpc64 above.

I'm not sure how strict we are about XPCOM_ABI bits for tier 2/3 platforms. Is GCC's ABI stable on those archs? Given the variety of other CPU_ARCH statements there, I'm guessing "not very strict".

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

http://hg.mozilla.org/mozilla-central/rev/3d5fd10b807c
with wildcard removed.

The main reason why the CPU_ARCHS need to get recognized is to allow xul apps (as Firefox) to find the correct XRE for multiarch installations which are common for ppc*/s390* (and x86-64) architectures.
AFAIK gcc's abi is (almost) identical across all platforms since gcc3 at least.

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 404296 [details] [diff] [review]
patch

Basically NPTOB for mozilla but keeps patch count lower for Linux distributions

Comment 5

[Wolfgang Rosenauer [:wolfiR]]

Asking wanted-1.9.2 as I'm wondering why that doesn't get approved or denied since weeks.

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 404296 [details] [diff] [review]
patch

Should have just marked this in the first place.

Comment 7

[Wolfgang Rosenauer [:wolfiR]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ba6fe09add7a

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-CC) Copy it to comm-central [Checkin: Comment 9]

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 429390 [details] [diff] [review]
(Bv1-CC) Copy it to comm-central
[Checkin: Comment 9]


http://hg.mozilla.org/comm-central/rev/803c436845db