509541 - thunderbird fails to properly attach source for HTML link

Status: NEW

(MailNews Core :: Composition, defect)

Description

[Matěj Cepl]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.1.2) Gecko/20090803 Fedora/3.5.2-2.fc11 Firefox/3.5.2
Build Identifier: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1.3pre) Gecko/20090810 Shredder/3.0b4pre

(originally filed as https://bugzilla.redhat.com/show_bug.cgi?id=490308)

Compose an email message containing no HTML formatting except for a link whose
text is identical to the link location.  In the Link Properties dialog, check
the "Attach the source of this link to the message" checkbox.

Make sure that the account where the message is sent from has in its setting checked "Compose message in HTML format" and that Composer has Options/Format set to the default "Auto".

Send the message.

The message will be sent as plaintext rather than as HTML or as
multipart/alternative.  This is the first bug.  If I insert a link into a
message, then that's HTML markup, and I expect HTML to be generated for the
message.

The second bug is that it fails to properly attach the source of the link as
you told it to do.  It inserts a "cid:" marker in the text of the message, but
this marker is useless because the indicated content ID isn't actually attached
to the message (and because it's a plaintext message rather than HTML).

If you put other HTML formatting into the message, e.g., bold or italic text,
then the message is sent as HTML and the attachment is included as requested.  

Reproducible: Always

Steps to Reproduce:
1.see above
2.
3.
Actual Results:  
The message is not in HTML and webpage is not attached. cid: URL points to nowhere.

Expected Results:  
Correctly formatted message (not sure where the message itself has to be HTML formatted), but the link should point to the attached webpage.

Comment 1

[Matěj Cepl]

The reproducer was incorrectly attached to another bug as attachment 393593 [details]

Comment 2

[Ludovic Hirlimann [:Usul]]

(In reply to comment #1)
> The reproducer was incorrectly attached to another bug as attachment 393593 [details]

Matej, What I see is two links one for google and a cid one. The google link works the cid one generates : 
Security Error: Content at mailbox:///Users/ludo/Documents/Testcases/2nd%20test%20for%20bug%20490308%20this%20time%20from%20the%20upstream%20binary.eml?type=application/x-message-display&number=0 may not load or link to about:blank.

Comment 3

[Matěj Cepl]

(In reply to comment #2)
> (In reply to comment #1)
> > The reproducer was incorrectly attached to another bug as attachment 393593 [details] [details]
> 
> Matej, What I see is two links one for google and a cid one. The google link
> works the cid one generates : 
> Security Error: Content at
> mailbox:///Users/ludo/Documents/Testcases/2nd%20test%20for%20bug%20490308%20this%20time%20from%20the%20upstream%20binary.eml?type=application/x-message-display&number=0
> may not load or link to about:blank.

That's exactly right ... cid: URL points to the attachment, which is missing from the message.

Comment 4

[Ludovic Hirlimann [:Usul]]

When you reproduce the error, do you see anything in the console.log ?

Comment 5

[Matěj Cepl]

Just

deliver mode: 0

and it is fully reproducible with Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1.3pre) Gecko/20090816 Shredder/3.0b4pre

Comment 6

[Matěj Cepl]

... and there is nothing in Tools/Error Console

Comment 7

[Ludovic Hirlimann [:Usul]]

Confirming the behaviour with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.3pre) Gecko/20090817 Shredder/3.0b4pre.

Standard8 do you think this could be related to a CORE composition bug ?

Comment 8

[WADA:World Anti-bad-Duping Agency]

With HTML mail of "Insert Link" only, "text/plain part only when Option/Format/Auto Detect" part was not reproduced with Tb trunk 2009/8/13 build on MS Win-XP SP3, with "Send Later". "text/plain part only" was observed only when Option/Format/Plain Text Only is intentionally selected.
  - Option/Format/Auto Detect:
    multipart/alternative with both text/plain & text/html was generated.
    text/html part has pointer of cid:, but no part of the cid:
    text/plain part is same as this bug. It's converted text from html part. 
  - Option/Format/Plain Text Only:
    text/plain part only in above multipart/alternative.

If HTML mail of text only, Bug 414299 occurs. This bug looks a variation of Bug 414299 when mail is "text only HTML" but data of web page will be attached.

Comment 9

[Russell Haley]

Since this bug is a prominent Google result for "thunderbird 'Attach the source of this link to the message'", which is how I got here after testing the feature with an email to myself and finding that it did nothing, I will ask here:

What is this checkbox supposed to do, when it it is working?

Comment 10

[Matěj Cepl]

(In reply to Russell Haley from comment #9)

Since this bug is a prominent Google result for "thunderbird 'Attach the source of this link to the message'", which is how I got here after testing the feature with an email to myself and finding that it did nothing, I will ask here:

Foremost, note the age of this bug (how many original participants on this bug can be even reached on their old email addresses?). Second, I have completely messed up this bug and bug 493204, so you should read both of them. Third I don’t use Thunderbird any more, so I am not sure what is the current status of this bug.

What is this checkbox supposed to do, when it it is working?

Should it download and attach the web page to the message?