[MARGIN-C]block vertical margins need rewrite

NEW
Unassigned

Status

()

Core
Layout: Block and Inline
P3
normal
17 years ago
4 years ago

People

(Reporter: dbaron, Unassigned)

Tracking

(Depends on: 1 bug, Blocks: 7 bugs, {css1, highrisk})

Trunk
Future
css1, highrisk
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9.1 -
wanted1.9.1 -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [CSS1-4.1.1])

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
I'm giving up on my attempts to fix most of the bugs in vertical margins on
blocks.  My changes are doing things that I didn't expect them to do, and I just
don't have the energy to look at this code anymore to figure out why not.  The
original changes were better in terms of correctness but crashed in some cases
(e.g., tinderbox popups).  The #if 0 code shows my original changes.

I will attach the changes that I am currently removing from my tree.  I will
attempt to pull the one or two easy fixes out of these changes and try and get
them checked in.  However, the margin code has serious problems and I don't
understand the block code well enough to fix them.
(Reporter)

Updated

17 years ago
Keywords: css1
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → Future
(Reporter)

Comment 1

17 years ago
Created attachment 13833 [details] [diff] [review]
work in progress that I am giving up on
(Reporter)

Updated

17 years ago
Summary: block vertical margins need rewrite → [MARGIN-C]block vertical margins need rewrite
(Reporter)

Comment 2

17 years ago
The changes here basically fix bug 50142 and bug 44242.  There are also other
related MARGIN-C bugs, some of which are compat issues that are less important
once we have released and set a precedent.  Some of those compat issues may be
fixed by these changes (or an improvement of these changes) as well.
Blocks: 44242, 50142
Keywords: ns6.01

Comment 3

17 years ago
dbaron, which bugs did you try to fix but failed (i.e. which other bugs would
this fix apart from bugs 44242,50142)?
(Reporter)

Comment 4

17 years ago
Those are the bugs I succeeded in fixing with these changes.  I was trying 
to fix many of the other bugs marked [MARGIN-C], e.g., bug 18206 (I may 
have had that fixed too), bug 29413, and bug 34404.  I hadn't yet thought of 
a good way to fix the compatibility [MARGIN-C] bugs.
Keywords: ns601 → highrisk, mozilla0.9
Keywords: nsbeta1

Comment 5

17 years ago
Is anyone else here willing to pick these changes up and run with them? I'm
currently trying to get involved with fixing layout bugs, but I've got a bunch
of learning to do first before I can really help fix bugs of this scope.
(Reporter)

Comment 6

16 years ago
Taking back.  Part of what the original rewrite did, plus other things, is being
done for bug 86947.
Assignee: buster → dbaron
(Reporter)

Updated

16 years ago
Status: NEW → ASSIGNED

Updated

16 years ago
Blocks: 104166
Attachment #13833 - Flags: needs-work+

Comment 7

15 years ago
Has there been any progress in the meantime?
(Reporter)

Updated

15 years ago
Component: Layout → Layout: Block & Inline

Updated

13 years ago
Whiteboard: [CSS1-4.1.1]
(Reporter)

Comment 8

10 years ago
So roc rewrote them again more recently, regressing performance significantly, and I think we need another rewrite, so this is still valid.
Assignee: dbaron → nobody
Status: ASSIGNED → NEW
QA Contact: chrispetersen → layout.block-and-inline

Updated

10 years ago
Blocks: 87277

Updated

10 years ago
Blocks: 372303

Updated

9 years ago
Flags: wanted1.9.1?
Flags: wanted1.9.1?
Flags: wanted1.9.1-
Flags: blocking1.9.1-

Updated

8 years ago
Blocks: 493380
(Reporter)

Updated

7 years ago
No longer blocks: 372303

Updated

6 years ago
Blocks: 33784, 166194, 376365, 451791, 616296, 616339
No longer blocks: 493380
Depends on: 477462

Updated

6 years ago
Blocks: 680761

Updated

4 years ago
Blocks: 521875
You need to log in before you can comment on or make changes to this bug.