510037 - Remove obsolete widget events

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Rob Arnold [:robarnold]]

They are not used anymore; I've checked with dbaron, smaug and mxr.

Comment 1

[Rob Arnold [:robarnold]]

Upon further review, nsMenuEvent can also be removed.

Comment 2

[Rob Arnold [:robarnold]]

Renaming the bug since I've now found more code to remove and it seems easier to post multiple small patches here than scatter them across many bugs.

Comment 3

[Rob Arnold [:robarnold]]

Attachment: Remove NS_CONTROL_CHANGE and NS_MENU_SELECT

Comment 4

[Rob Arnold [:robarnold]]

Attachment: Remove unused fields and message handlers from nsWindow

This patch removes more dead code from nsWindow, in particular obsolete code related to native controls.

Comment 5

[Rob Arnold [:robarnold]]

Other events/code that can go:

NS_WILL_PAINT - only used by nsWindowGfx and handled as NS_PAINT
NS_TABCHANGE
NS_OS_TOOLBAR and nsWebShellWindow::Toolbar
NS_DISPLAYCHANGED - only dispatched on NT systems but the handler appears to do nothing
NS_SCROLLBAR_*

Comment 6

[Rob Arnold [:robarnold]]

hmm, NS_WILL_PAINT is actually used it seems. I should have looked harder.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 442564 [details] [diff] [review]
Remove NS_CONTROL_CHANGE and NS_MENU_SELECT

You need to remove some code also here
http://mxr.mozilla.org/mozilla-central/source/widget/src/photon/nsWidget.cpp#662

Comment 8

[Jim Mathies [:jimm]]

Comment on attachment 442565 [details] [diff] [review]
Remove unused fields and message handlers from nsWindow

builds fine.

I tried tracing some of this back via Bonsai, most of the code was checked in back when the cvs repo was created.

Comment 9

[Rob Arnold [:robarnold]]

(In reply to comment #7)
> (From update of attachment 442564 [details] [diff] [review])
> You need to remove some code also here
> http://mxr.mozilla.org/mozilla-central/source/widget/src/photon/nsWidget.cpp#662

This is being removed in bug 563462.

Comment 10

[Rob Arnold [:robarnold]]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/dd135aa06b4e
http://hg.mozilla.org/mozilla-central/rev/44d9cb4f5796