Status

defect
RESOLVED FIXED
9 years ago
5 years ago

People

(Reporter: robarnold, Assigned: robarnold)

Tracking

Trunk
mozilla8
x86
Windows 7
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments)

It is dead unmaintained code. The graphics bits were removed just under 22 months (that's 2 major releases) ago. In particular, bug 447693 comment 3 indicates that there the 1.8 branch is the active branch. This code is untested and likely suffers from bitrot due to the massive changes that have occurred to the tree since the 1.8 branch (namely cairo, TraceMonkey, OOPP, focus manager rewrite) and will likely continue to do so for future features (hardware acceleration, OOP tabs).
Assignee: amardare → tellrob
Status: NEW → ASSIGNED
Attachment #443196 - Flags: review?(vladimir)
Attachment #443198 - Flags: review?
Attachment #443198 - Flags: review? → review?(cbiesinger)
Attachment #443200 - Flags: review?(dtownsend)
Attachment #443197 - Flags: review?(vladimir)
Attachment #443197 - Flags: review?(ted.mielczarek)
Attachment #443197 - Flags: review?(jwalden+bmo)
Comment on attachment 443199 [details] [diff] [review]
Remove from libpref

I could not find an owner for libpref on http://www.mozilla.org/about/owners.html but dwitte has reviewed at least one libpref patch recently so he gets this one too.
Attachment #443199 - Flags: review?(dwitte)
Attachment #443197 - Flags: review?(jwalden+bmo) → review+
Comment on attachment 443199 [details] [diff] [review]
Remove from libpref

r=dwitte
Attachment #443199 - Flags: review?(dwitte) → review+
Attachment #443198 - Flags: review?(cbiesinger) → review+
Attachment #443200 - Flags: review?(dtownsend) → review+
Comment on attachment 443197 [details] [diff] [review]
Remove non-toolkit build system bits

Thanks for the cleanup!
Attachment #443197 - Flags: review?(ted.mielczarek) → review+
The build-system bits never landed. I'll update Rob's patch to build-system tip later today.
Rob's patch, with him as the patch author, based on build-system tip, ready for checkin.
Attachment #541862 - Flags: review+
Attachment #541862 - Flags: checkin?
Comment on attachment 541862 [details] [diff] [review]
Remove non-toolkit build system bits updated

http://hg.mozilla.org/integration/mozilla-inbound/rev/5579c4b5623e
Attachment #541862 - Flags: checkin? → checkin+
Whiteboard: [inbound]
Backed-out from inbound due to a perma-orange, see:
http://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0adaae140642

The patch in this bug might not bee related, the entire push has been backed out.
Whiteboard: [inbound]
(In reply to Justin Wood (:Callek) from comment #12)
> Comment on attachment 541862 [details] [diff] [review]
> Remove non-toolkit build system bits updated
> 
> http://hg.mozilla.org/integration/mozilla-inbound/rev/5579c4b5623e

(In reply to Mounir Lamouri (:volkmar) from comment #13)
> Backed-out from inbound due to a perma-orange, see:
> http://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0adaae140642
> 
> The patch in this bug might not bee related, the entire push has been backed
> out.

Relanded as: http://hg.mozilla.org/integration/mozilla-inbound/rev/a7f8e93c6e22
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/a7f8e93c6e22
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Blocks: 807488
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.