563462 - Remove support for Photon

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Photon, defect)

Description

[Rob Arnold [:robarnold]]

It is dead unmaintained code. The graphics bits were removed just under 22 months (that's 2 major releases) ago. In particular, bug 447693 comment 3 indicates that there the 1.8 branch is the active branch. This code is untested and likely suffers from bitrot due to the massive changes that have occurred to the tree since the 1.8 branch (namely cairo, TraceMonkey, OOPP, focus manager rewrite) and will likely continue to do so for future features (hardware acceleration, OOP tabs).

Comment 1

[Rob Arnold [:robarnold]]

Attachment: Remove widget/ bits

Comment 2

[Rob Arnold [:robarnold]]

Attachment: Remove non-toolkit build system bits

Comment 3

[Rob Arnold [:robarnold]]

Attachment: Remove netwerk/ bits

Comment 4

[Rob Arnold [:robarnold]]

Attachment: Remove from libpref

Comment 5

[Rob Arnold [:robarnold]]

Attachment: Remove from toolkit/

Comment 6

[Rob Arnold [:robarnold]]

Comment on attachment 443199 [details] [diff] [review]
Remove from libpref

I could not find an owner for libpref on http://www.mozilla.org/about/owners.html but dwitte has reviewed at least one libpref patch recently so he gets this one too.

Comment 7

[[e-mail]]

Comment on attachment 443199 [details] [diff] [review]
Remove from libpref

r=dwitte

Comment 8

[Rob Arnold [:robarnold]]

Pushed all but the build system bits to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/d3a42a17157b
http://hg.mozilla.org/mozilla-central/rev/b3bae06509be
http://hg.mozilla.org/mozilla-central/rev/b0e6cec6c890
http://hg.mozilla.org/mozilla-central/rev/e754ea37b4c4

Just need Ted's review and photon will be gone.

Comment 9

[(not currently active) Ted Mielczarek]

Comment on attachment 443197 [details] [diff] [review]
Remove non-toolkit build system bits

Thanks for the cleanup!

Comment 10

[Matheus Kerschbaum]

The build-system bits never landed. I'll update Rob's patch to build-system tip later today.

Comment 11

[Matheus Kerschbaum]

Attachment: Remove non-toolkit build system bits updated

Rob's patch, with him as the patch author, based on build-system tip, ready for checkin.

Comment 12

[Justin Wood (:Callek)]

Comment on attachment 541862 [details] [diff] [review]
Remove non-toolkit build system bits updated

http://hg.mozilla.org/integration/mozilla-inbound/rev/5579c4b5623e

Comment 13

[Mounir Lamouri (:mounir)]

Backed-out from inbound due to a perma-orange, see:
http://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0adaae140642

The patch in this bug might not bee related, the entire push has been backed out.

Comment 14

[Justin Wood (:Callek)]

(In reply to Justin Wood (:Callek) from comment #12)
> Comment on attachment 541862 [details] [diff] [review]
> Remove non-toolkit build system bits updated
> 
> http://hg.mozilla.org/integration/mozilla-inbound/rev/5579c4b5623e

(In reply to Mounir Lamouri (:volkmar) from comment #13)
> Backed-out from inbound due to a perma-orange, see:
> http://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0adaae140642
> 
> The patch in this bug might not bee related, the entire push has been backed
> out.

Relanded as: http://hg.mozilla.org/integration/mozilla-inbound/rev/a7f8e93c6e22

Comment 15

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/a7f8e93c6e22