The default bug view has changed. See this FAQ.

Remove support for Photon

RESOLVED FIXED in mozilla8

Status

Core Graveyard
Widget: Photon
RESOLVED FIXED
7 years ago
2 years ago

People

(Reporter: robarnold, Assigned: robarnold)

Tracking

Trunk
mozilla8
x86
Windows 7
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments)

(Assignee)

Description

7 years ago
It is dead unmaintained code. The graphics bits were removed just under 22 months (that's 2 major releases) ago. In particular, bug 447693 comment 3 indicates that there the 1.8 branch is the active branch. This code is untested and likely suffers from bitrot due to the massive changes that have occurred to the tree since the 1.8 branch (namely cairo, TraceMonkey, OOPP, focus manager rewrite) and will likely continue to do so for future features (hardware acceleration, OOP tabs).
(Assignee)

Comment 1

7 years ago
Created attachment 443196 [details] [diff] [review]
Remove widget/ bits
Assignee: amardare → tellrob
Status: NEW → ASSIGNED
Attachment #443196 - Flags: review?(vladimir)
(Assignee)

Comment 2

7 years ago
Created attachment 443197 [details] [diff] [review]
Remove non-toolkit build system bits
(Assignee)

Comment 3

7 years ago
Created attachment 443198 [details] [diff] [review]
Remove netwerk/ bits
Attachment #443198 - Flags: review?
(Assignee)

Updated

7 years ago
Attachment #443198 - Flags: review? → review?(cbiesinger)
(Assignee)

Comment 4

7 years ago
Created attachment 443199 [details] [diff] [review]
Remove from libpref
(Assignee)

Comment 5

7 years ago
Created attachment 443200 [details] [diff] [review]
Remove from toolkit/
Attachment #443200 - Flags: review?(dtownsend)
(Assignee)

Updated

7 years ago
Attachment #443197 - Flags: review?(vladimir)
Attachment #443197 - Flags: review?(ted.mielczarek)
Attachment #443197 - Flags: review?(jwalden+bmo)
(Assignee)

Comment 6

7 years ago
Comment on attachment 443199 [details] [diff] [review]
Remove from libpref

I could not find an owner for libpref on http://www.mozilla.org/about/owners.html but dwitte has reviewed at least one libpref patch recently so he gets this one too.
Attachment #443199 - Flags: review?(dwitte)
Attachment #443197 - Flags: review?(jwalden+bmo) → review+
Attachment #443197 - Flags: review?(vladimir) → review+
Attachment #443196 - Flags: review?(vladimir) → review+

Comment 7

7 years ago
Comment on attachment 443199 [details] [diff] [review]
Remove from libpref

r=dwitte
Attachment #443199 - Flags: review?(dwitte) → review+
Attachment #443198 - Flags: review?(cbiesinger) → review+
Attachment #443200 - Flags: review?(dtownsend) → review+
(Assignee)

Comment 8

7 years ago
Pushed all but the build system bits to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/d3a42a17157b
http://hg.mozilla.org/mozilla-central/rev/b3bae06509be
http://hg.mozilla.org/mozilla-central/rev/b0e6cec6c890
http://hg.mozilla.org/mozilla-central/rev/e754ea37b4c4

Just need Ted's review and photon will be gone.
Comment on attachment 443197 [details] [diff] [review]
Remove non-toolkit build system bits

Thanks for the cleanup!
Attachment #443197 - Flags: review?(ted.mielczarek) → review+

Comment 10

6 years ago
The build-system bits never landed. I'll update Rob's patch to build-system tip later today.

Comment 11

6 years ago
Created attachment 541862 [details] [diff] [review]
Remove non-toolkit build system bits updated

Rob's patch, with him as the patch author, based on build-system tip, ready for checkin.
Attachment #541862 - Flags: review+
Attachment #541862 - Flags: checkin?
Comment on attachment 541862 [details] [diff] [review]
Remove non-toolkit build system bits updated

http://hg.mozilla.org/integration/mozilla-inbound/rev/5579c4b5623e
Attachment #541862 - Flags: checkin? → checkin+

Updated

6 years ago
Whiteboard: [inbound]
Backed-out from inbound due to a perma-orange, see:
http://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0adaae140642

The patch in this bug might not bee related, the entire push has been backed out.
Whiteboard: [inbound]
(In reply to Justin Wood (:Callek) from comment #12)
> Comment on attachment 541862 [details] [diff] [review]
> Remove non-toolkit build system bits updated
> 
> http://hg.mozilla.org/integration/mozilla-inbound/rev/5579c4b5623e

(In reply to Mounir Lamouri (:volkmar) from comment #13)
> Backed-out from inbound due to a perma-orange, see:
> http://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0adaae140642
> 
> The patch in this bug might not bee related, the entire push has been backed
> out.

Relanded as: http://hg.mozilla.org/integration/mozilla-inbound/rev/a7f8e93c6e22
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/a7f8e93c6e22
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8

Updated

5 years ago
Blocks: 807488
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.