510062 - buildbot masters should prioritize stable branches above projects branches

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

...but still prioritize all release work above everything else. So, that means:
releases > mozilla-{central,1.9.1,1.9.2} > tracemonkey,places,electrolysis

Comment 1

[alice nodelman [:alice] [:anode]]

Futuring as an enhancement.

Comment 3

[Chris Cooper [:coop] (he/him)]

Mass move of bugs from Release Engineering:Future -> Release Engineering. See
http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.

Comment 4

[Chris Cooper [:coop] (he/him)]

Attachment: Prioritize m-c, 1.9.2, and 1.9.2 ahead of other branches

catlee just touched this code today, so he wins the review request.

Comment 5

[Chris AtLee [:catlee]]

Comment on attachment 495932 [details] [diff] [review]
Prioritize m-c, 1.9.2, and 1.9.2 ahead of other branches

config.py is reloaded after master_common in builder_master.cfg, so changes to PRIORITY_BRANCHES wouldn't take effect at the first reconfig.

Also, the mozilla-tests/ masters also use master_common.py, so config.py (or wherever the list ends up) will have to be updated there as well.

Comment 6

[Chris Cooper [:coop] (he/him)]

(In reply to comment #5)
> config.py is reloaded after master_common in builder_master.cfg, so changes to
> PRIORITY_BRANCHES wouldn't take effect at the first reconfig.

What's the recommended way to make this reconfig-safe then? Move PRIORITY_BRANCHES into master_common?

Comment 7

[Chris Cooper [:coop] (he/him)]

Attachment: Prioritize m-c, 1.9.2, and 1.9.2 ahead of other branches, v2

Comment 8

[Chris Cooper [:coop] (he/him)]

Comment on attachment 496798 [details] [diff] [review]
Prioritize m-c, 1.9.2, and 1.9.2 ahead of other branches, v2

Moves the PRIORITY_BRANCHES list into master_common to facilitate reconfigs, as discussed in IRC.

Comment 9

[Chris AtLee [:catlee]]

Comment on attachment 496798 [details] [diff] [review]
Prioritize m-c, 1.9.2, and 1.9.2 ahead of other branches, v2

I think instead of "and builder.properties['branch']" we should be doing "and 'branch' in builder.properties", or whatever the properties equivalent is.  The code as it is risks raising a KeyError of the builder doesn't have 'branch'.

r+ with that change.

Comment 10

[Chris Cooper [:coop] (he/him)]

(In reply to comment #9) 
> I think instead of "and builder.properties['branch']" we should be doing "and
> 'branch' in builder.properties", or whatever the properties equivalent is.  The
> code as it is risks raising a KeyError of the builder doesn't have 'branch'.

builder.properties.has_key('branch') is what we want here. Fixed.

Comment 11

[Chris Cooper [:coop] (he/him)]

Comment on attachment 496798 [details] [diff] [review]
Prioritize m-c, 1.9.2, and 1.9.2 ahead of other branches, v2

Landed so it run in preproduction:

http://hg.mozilla.org/build/buildbot-configs/rev/2947e16e6502

Comment 12

[coop]

Comment on attachment 495932 [details] [diff] [review]
Prioritize m-c, 1.9.2, and 1.9.2 ahead of other branches

i just want all these bugs out of my computer. please help!!!

Comment 13

[coop]

Comment on attachment 495932 [details] [diff] [review]
Prioritize m-c, 1.9.2, and 1.9.2 ahead of other branches

i just want all these bugs out of my computer. please help!!! and how can i write in here before if this is my first time ever being here?? i would even be here if my computer wasn't **** up!! so please help me fix all the bugs on my computer. PLEASE

Comment 14

[coop]

(In reply to comment #10)
> (In reply to comment #9) 
> > I think instead of "and builder.properties['branch']" we should be doing "and
> > 'branch' in builder.properties", or whatever the properties equivalent is.  The
> > code as it is risks raising a KeyError of the builder doesn't have 'branch'.
> 
> builder.properties.has_key('branch') is what we want here. Fixed.

HOW CAN I COMMENT ON SOMETHING IF I WAS NEVER HERE BEFORE!!!!!!!!!

Comment 15

[Chris Cooper [:coop] (he/him)]

(In reply to comment #14)
> HOW CAN I COMMENT ON SOMETHING IF I WAS NEVER HERE BEFORE!!!!!!!!!

Please stop.

If you need help with Mozilla products, please start here:

http://support.mozilla.com/en-US/home/

Comment 16

[[e-mail] (:bhearsum)]

Comment on attachment 496798 [details] [diff] [review]
Prioritize m-c, 1.9.2, and 1.9.2 ahead of other branches, v2

Landed on production branch

Comment 17

[[e-mail] (:bhearsum)]

Clearing reconfig flag.