510378 - Consider enabling Satchel/Form Fill in Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

Form fill is a useful part of content browsing.

The most useful application for form fill in Thunderbird is to allow passwords to be entered in the case of multiple passwords per user.

This will also bring us another step closer to core.

The core part of this is in bug 510377, the patch here includes the relevant files in the build and extends the content tabs to take advantage of form fill. I'll request review once we get the core patch in.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix v2

Updated patch. Now that the core patch to enable satchel (in bug 510377) has sr, I'd like to move this forward especially as applying it without the core patch doesn't actually affect anything.

Testing is a little bit harder at the moment. The simplest way I can think of is:

1) apply patch from bug 510377 to core, along with this patch. Set network.protocol-handler.expose-all to true. In nsMsgWindow::IsPreferred change *aCanHandleContent to be set to PR_TRUE. Build Thunderbird. 

2) Start Thunderbird, in error console enter:

Components.classes['@mozilla.org/appshell/window-mediator;1'].getService(Components.interfaces.nsIWindowMediator).getMostRecentWindow("mail:3pane").document.getElementById("tabmail").openTab("contentTab", {contentPage: "http://bugzilla.mozilla.org"});

and evaluate.

3) Enter a bug number in the find field.

4) Then navigate back to the same page and start to enter the same number. The form fill autocomplete suggestion should appear.

Comment 2

[Phil Ringnalda (:philor)]

Comment on attachment 396983 [details] [diff] [review]
The fix v2

>+++ b/mail/app/profile/all-thunderbird.js
>\ No newline at end of file

I think a newline would look good there :)

Comment 3

[Mark Banner (:standard8)]

I checked this in with a couple of changes to the packages files, so that we can have builds on trunk with this working whilst we're awaiting 1.9.1 approvals.

The packages changes were to add appropriate MOZILLA_1_9_1_BRANCH ifdefs and add nsFormAutoComplete.js which is a trunk-only file. I also added the files to removed-files.in for now to support downgrades etc.

http://hg.mozilla.org/comm-central/rev/3e1287030b09

Comment 4

[Joe Sabash [:JoeS1]]

Since this checkin:
Error: Components.classes['@mozilla.org/satchel/form-fill-controller;1'] is undefined
Source file: chrome://global/content/bindings/browser.xml
Line: 400
Has been appearing in the error console.

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> Since this checkin:
> Error: Components.classes['@mozilla.org/satchel/form-fill-controller;1'] is
> undefined

Assuming that's on the 3.0b4pre builds just ignore it for now and when we get approval for bug 510377 to land on 1.9.1 it'll be fixed.

Comment 6

[Mark Banner (:standard8)]

Now that bug 510377 is on 1.9.1, I've tweaked the packaging to include it on our builds:

http://hg.mozilla.org/comm-central/rev/d7402d37bd3b

Therefore marking this fixed.

Comment 7

[jenzed]

Mark updated the "Thunderbird 3 for developers" MDC page (https://developer.mozilla.org/En/Thunderbird_3_for_developers#Form_Fill)