510410 - remove remaining Carbon usage in Mac OS X native menu impl on 10.5+

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Josh Aas]

We should remove remaining Carbon usage in our Mac OS X native menu impl on 10.5+. We can't do this on 10.4 because we don't have the APIs we need. This will also make our native menu impl 64-bit ready.

Comment 1

[Josh Aas]

Attachment: fix v1.0

Comment 2

[Josh Aas]

In order to test this you need a 32-bit build with the following in your mozconfig (crash reporter won't work when targeting 10.5):

ac_add_options --with-macos-sdk=/Developer/SDKs/MacOSX10.5.sdk
ac_add_options --enable-macos-target=10.5
ac_add_options --disable-crashreporter

Comment 3

[Josh Aas]

Attachment: fix v1.1

Forgot to take care of the header file.

Comment 4

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/e6bca323cf1e

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #2)
> In order to test this you need a 32-bit build with the following in your
> mozconfig (crash reporter won't work when targeting 10.5):

Assuming that's the same error as we used to see with the 10.5 SDK (http://forums.mozillazine.org/viewtopic.php?f=12&t=1204525), you should push for a Breakpad update on relevant branches; it's been fixed upstream since April (see bug 429841 comment 9).