510460 - some test in queries/test_redirectsMode.js is disabled, fix and re-enable them.

Status: RESOLVED WORKSFORME

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

some test is failing and marked with XXX, that should be fixed.

Comment 1

[Shawn Wilsher :sdwilsh]

OS X 10.5.2 mozilla-central test opt everythingelse on 2009/10/22 11:11:40  
http://tinderbox.mozilla.org/showlog.cgi?tree=Firefox-Unittest&errorparser=unittest&logfile=1256235100.1256237052.29549.gz&buildtime=1256235100&buildname=OS%20X%2010.5.2%20mozilla-central%20test%20opt%20everythingelse&fulltext=1#err2

Comment 2

[Shawn Wilsher :sdwilsh]

OS X 10.5.2 mozilla-central test everythingelse [testfailed] Started 11:57, finished 12:34
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1256237857.1256239988.30269.gz&fulltext=1

Comment 4

[Shawn Wilsher :sdwilsh]

OS X 10.5.2 mozilla-central test opt everythingelse [testfailed] Started 14:54, finished 15:31
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1256248480.1256250602.17951.gz&fulltext=1

Comment 5

[Timothy Nikkel (:tnikkel)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1256372298.1256374159.4102.gz

Comment 6

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1256539620.1256542181.29305.gz
OS X 10.5.2 mozilla-central test everythingelse on 2009/10/25 23:47:00

Comment 7

[Marco Bonardo [:mak]]

this bug was intended to fix XXX disabled bugs, not to handle random failures :(
byt i should have named it better.

Comment 8

[Phil Ringnalda (:philor)]

I thought that the first time I looked at comment 0, but then I looked at http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/queries/test_redirectsMode.js and didn't find a single instance of XXX, and only one of todo, which didn't match with the date you filed (not that anything else seems to), so after ignoring four or five failures, I figured I might as well join the pile-on ;)

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(In reply to comment #7)
> this bug was intended to fix XXX disabled bugs, not to handle random failures
> :(
> byt i should have named it better.

That's why I told sdwilsh I filed bug 523578 as a separate bug. :-)

Comment 10

[Phil Ringnalda (:philor)]

There, I fixed it.

Comment 11

[Mark Banner (:standard8)]

Redirects mode was removed in bug 737841.