Closed Bug 510565 Opened 15 years ago Closed 5 years ago

Geolocation notification does not show requester of location for file:// URIs

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: mmcnicklebugs, Assigned: mmcnicklebugs)

Details

Attachments

(1 file)

Patch
2.27 KB, patch
dougt
: review+
Gavin
: review+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.1.2) Gecko/20090729 Firefox/3.1 Build Identifier: Same issue as bug 510424 but also on mobile version. Reproducible: Always
Attached patch Patch — — Splinter Review
There could potentially be an issue with long filenames and limitied space in the browser window.
Attachment #394551 - Flags: review?(doug.turner)
Attachment #394551 - Flags: review?(gavin.sharp)
Attachment #394551 - Flags: review?(doug.turner)
Attachment #394551 - Flags: review+
Assignee: nobody → doug.turner
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee: doug.turner → mmcnicklebugs
Comment on attachment 394551 [details] [diff] [review] Patch I'd probably use an "instanceof Ci.nsIFileURL" check rather than schemeIs. It seems like we should somehow make the user aware that the local file can send the location wherever it wants - they might have the expectation that "a local file wants to know" implies that their location will be kept locally, and that isn't necessarily the case.
Attachment #394551 - Flags: review?(gavin.sharp) → review+
Looks like this patch was forgotten somehow. It probably still applies cleanly, if someone wants to refresh it to apply to mozilla-central.
Closing all opened bug in a graveyard component
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: