510603 - Review error handling of custom search terms and filter actions

Status: NEW

(MailNews Core :: Filters, defect)

Description

[Kent James (:rkent)]

The custom search terms of bug 495519 detect the presence of a custom search term using isNaN, which interprets virtually anything unknown (including null and undefined) as a custom search term. Attachment 394324 [details] [diff] from bug 506199 attempted to centralize the detection of customSearchTerms, and prevent items that resolve to false from being so detected. But that was beyond the cope of that bug, so we split it off to this new bug.

As a related item (though perhaps should be its own bug), bug 495519 also prevents the saving of invalid filters, and throws up an error dialog saying "This filter cannot be saved because some search terms are invalid in the current context." This seems to be confusing when encountered, and perhaps needs rethinking as well. Perhaps it needs more explanation? And should we allow people to save their filters even though invalid? I've received reports of people whose filters (in their opinion) were working just fine, yet gave this message and could not be edited. This message will be encountered more often as the capabilities of message filters are expanding, creating more cases where a filter will work in one context, but not another.

Comment 1

[Wayne Mery (:wsmwk)]

Hi Kent. I just got "This filter cannot be saved because some search terms are invalid in the current context" when adding a subject contains rule to an already existing list.  I received it twice.  Then, before clicking OK the third time I merely clicked in the text field of the rule, then OK, it it saved fine.

1. open filter
2. click + in middle of existing list
3. add subject contains rule "455650]"
4. click OK
fails to save

deserves new bug?

Comment 2

[Kent James (:rkent)]

Yes new one.  The point of this bug is to look at the error messages, because so many of these messages that appear really are not about custom filters at all.  Your case is a perfect example.  The problem itself deserves a new bug.

Comment 3

[Wayne Mery (:wsmwk)]

bug 551707 be made to block this, or vice versa?  (or related)