510664 - Create multi-state flag for blocking1.9.3

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[(mostly gone) XtC4UaLL [:xtc4uall]]

since branching happened, isn't it time about getting the next generation of flags?

blocking‑firefox3.7
wanted‑firefox3.7
blocking1.9.3
wanted1.9.3

Comment 1

[Samuel Sidler (old account; do not CC)]

Before we do this, there's some discussion that needs to happen around if we're going to use multi-state flags here (and go back and add them for 1.9.2) and if we're going to unify the flags so there's not two types (in this case, 1.9.3 and firefox3.7).

I think that discussion's happening early next week.

Comment 2

[Samuel Sidler (old account; do not CC)]

Just talked with beltzner.

I think we're going to try a few things. First, we're going to get rid of the blocking-firefox flags and replace it with blocking1.9.3 flags.

Second, we're going to switch to a multi-state flag, like we're doing for 1.9.1.x work.

The flag should have the following values:

  value     weight     settable by
  ---       100        anyone
  ?         110        anyone
  -         120        mozilla-1.9-drivers
  alpha1    200        mozilla-1.9-drivers
  beta1     300        mozilla-1.9-drivers
  final     400        mozilla-1.9-drivers

Reed did this for us previously in bug 502769, but I'm guessing we'll need Dave to do it this round.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

bumping priority for this -- we currently have no way to mark 1.9.3 bugs currently, and we've already branched!

Comment 4

[Samuel Sidler (old account; do not CC)]

CCing Server Ops so it gets on their radar (or should I just assign it to them?).

Comment 5

[Dave Miller [:justdave]]

I can get this for you by early Wednesday at the earliest.  We're still using a local hack for this, so it requires code changes in Bugzilla every time we add one, and I'm not going to have time to hack on it until later tonight.

Comment 6

[Daniel Veditz [:dveditz]]

Do we need status1.9.3 fields at the same time, or do we stick with keywords until we branch?

Comment 7

[Samuel Sidler (old account; do not CC)]

No keywords needed for the 1.9.3 "branch" since it's trunk. RESOLVED FIXED will do.

Comment 8

[Samuel Sidler (old account; do not CC)]

Wednesday morning has come and gone. Any status update here?

Comment 9

[Samuel Sidler (old account; do not CC)]

It's now Friday evening. Where are we on this?

This is hurting the development team since they can't triage bugs for 1.9.3.

Comment 10

[Dave Miller [:justdave]]

I was told that getting the choppy phone call reporting thing into the phone system was higher priority than this, so I've been working on that.

Comment 11

[Dave Miller [:justdave]]

ETA for both is late evening tonight, though (I had some work in on the new status flags before getting diverted to that).

Comment 12

[Dave Miller [:justdave]]

taking longer than I expected, will probably be this afternoon yet.  This is back on top now though.

Comment 13

[Dave Miller [:justdave]]

Done and deployed.

I also made the code on the back end much more generic.  Any future additions of blocking-* flags using this same product and permission combination will only require a one-line addition to 1 file instead of multiple changes to 6 (thus saving you much aggravation and waiting next time).

Comment 14

[Samuel Sidler (old account; do not CC)]

This isn't actually done right. It's apparently set to use mozilla-stable-branch-drivers instead of mozilla-1.9-drivers as requested.

Comment 15

[Dave Miller [:justdave]]

Committing to: /var/www/html/bmo/3.2/
modified Bugzilla/Bug.pm
Committed revision 6202.

Should have it deployed in the next 10 min or so.

Comment 16

[Samuel Sidler (old account; do not CC)]

Still not right. Working with Dave on IRC...

Comment 17

[Samuel Sidler (old account; do not CC)]

Reopening.

Comment 18

[Dave Miller [:justdave]]

OK, to summaries the current problem...

- ss is a member of mozilla-stable-branch-drivers
- bsmedberg is a member of mozilla-1.9-drivers
- neither is a member of both groups
- bsmedberg only sees ? on both 1.9.3 and 1.9.1
  - he should be able to see everything on 1.9.3 and only ? on 1.9.1
- ss can see everything on both 1.9.3 and 1.9.1
  - he should be able to see everything on 1.9.1 and only ? on 1.9.3

Short version: the mozilla-stable-branch-drivers permission appears to be applying to both flags, which implies that the elsif for cf_blocking_193 isn't firing...

Comment 19

[Dave Miller [:justdave]]

Committing to: /var/www/html/bmo/3.2/
modified template/en/default/bug/field.html.tmpl
Committed revision 6205.

and live.  One other spot in the template that was checking the groups separately.

Comment 20

[(mostly gone) XtC4UaLL [:xtc4uall]]

so the idea of "wanted"-flags got depreciated for branches >= 1.9.3?

Comment 21

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #20)
> so the idea of "wanted"-flags got depreciated for branches >= 1.9.3?

Dave or Sam, any answer for that? Why don't we use wanted flags anymore? Have I missed a post?