510703 - NEW Message filters are created with garbage names

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[Bill Davidsen]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.3pre) Gecko/20090814 SeaMonkey/2.0b2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.3pre) Gecko/20090814 SeaMonkey/2.0b2pre

Creating any new message filter generates a filter rule which uses the first match rule as the name of the filter. Creating multiple filters with the same first rule creates multiple rules with the same name.

Reproducible: Always

Steps to Reproduce:
1.click tools->message filters from mail/news
2.create a filter with name and at least one rule
3.save the rule
Actual Results:  
filter appears named something like "Subject: dog ****" instead of the name chosen at creation.

Expected Results:  
The contents of the "filter name" box would be used as the name of the filter

Comment 1

[Kent James (:rkent)]

This bug is a regression from bug 457745, as noted in bug 457745 comment 61. I'm not aware of any other filings of this though that could be used to track the fix.

Comment 2

[Magnus Melin [:mkmelin]]

Matt: from bug 457745.

Comment 3

[Bill Davidsen]

There isn't enough information to create a "meaningful name" for a filter if the user doesn't provide one. The old behavior, calling to an "unnamed filter" with a unique number was actually a more meaningful name!

Therefore:
1 - revert 457745, it wasn't a bug and isn't a solution
2 - is user supplied names are a big deal, use a pop-up with the OLD default name
    and a "is this what you really want?" prompt. The user can click OKAY, or
    ENTER to use the default, or type over the default name, as "save" does in
    the browser.

If it's not broke, don't fix it!

Comment 5

[Tony Mechelynck [:tonymec]]

(In reply to comment #3)
[...]
> If it's not broke, don't fix it!

and in particular, if the user does provide a meaningful and unique name, don't override it with something less meaningful and possibly not even unique!

Comment 6

[Matt Dudziak]

Attachment: Patch to avoid override of user-selected name and to handle Attachment and Junk Status rules correctly

A patch to fix the problem stated in this bug where a user-defined name is overwritten. Also addresses the problems Neil pointed out in https://bugzilla.mozilla.org/show_bug.cgi?id=457745#c64

Comment 7

[[e-mail]]

Comment on attachment 400908 [details] [diff] [review]
Patch to avoid override of user-selected name and to handle Attachment and Junk Status rules correctly

>+    gFilter = gFilterList.createFilter(filtername);
filterName has a capital N. r=me with that fixed.

Comment 8

[Matt Dudziak]

Attachment: Patch to avoid override of user-selected name and to handle Attachment and Junk Status rules correctly. With proper capitalization this time. [Checkin: Comment 10]

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 401041 [details] [diff] [review]
Patch to avoid override of user-selected name and to handle Attachment and Junk Status rules correctly. With proper capitalization this time.
[Checkin: Comment 10]

The tree policy currently requires approval for checkin (as mentioned on the newsgroups and tinderboxes). It is helpful if you can request that before checkin-needed.

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 401041 [details] [diff] [review]
Patch to avoid override of user-selected name and to handle Attachment and Junk Status rules correctly. With proper capitalization this time.
[Checkin: Comment 10]


http://hg.mozilla.org/comm-central/rev/dfca16744cae