510724 - JavaScript warning when hitting "n" to go to the next unread message.

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Blake Winton (:bwinton) (:☕️)]

Attachment: A patch to fix the missing variable warning [Checkin: Comment 5]

I was testing out a fix for another bug, when I saw this message in my console.

JavaScript strict warning: chrome://messenger/content/msgViewNavigation.js, line 130: assignment to undeclared variable i

It's been bugging me for a while, so here's a small patch to get rid of it.
(I used "var" instead of "let", because that's what the for loops near it used.)

Thanks,
Blake.

Comment 1

[David :Bienvenu]

Comment on attachment 394678 [details] [diff] [review]
A patch to fix the missing variable warning
[Checkin: Comment 5]

though using let would be fine as well.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 394678 [details] [diff] [review]
A patch to fix the missing variable warning
[Checkin: Comment 5]

var is the safer bet here since 'i' is used outside of the for block.

Comment 3

[David :Bienvenu]

ouch, yay for more context :-(

Comment 4

[Blake Winton (:bwinton) (:☕️)]

I don't know if it would have helped in this case, but I've since switched my mercurial diff options to:
git = true
showfunc = 1
unified = 8
as per https://developer.mozilla.org/en/Mercurial_FAQ#Configuration

It makes the diffs look way bigger, but then again, that might not be so bad.

Thanks,
Blake.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 394678 [details] [diff] [review]
A patch to fix the missing variable warning
[Checkin: Comment 5]


http://hg.mozilla.org/comm-central/rev/d13680105f86