Closed
Bug 510724
Opened 12 years ago
Closed 12 years ago
JavaScript warning when hitting "n" to go to the next unread message.
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b4
People
(Reporter: bwinton, Assigned: bwinton)
Details
Attachments
(1 file)
980 bytes,
patch
|
asuth
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
I was testing out a fix for another bug, when I saw this message in my console. JavaScript strict warning: chrome://messenger/content/msgViewNavigation.js, line 130: assignment to undeclared variable i It's been bugging me for a while, so here's a small patch to get rid of it. (I used "var" instead of "let", because that's what the for loops near it used.) Thanks, Blake.
Attachment #394678 -
Flags: superreview?(bienvenu)
Attachment #394678 -
Flags: review?(bugmail)
Updated•12 years ago
|
Attachment #394678 -
Flags: superreview?(bienvenu) → superreview+
Comment 1•12 years ago
|
||
Comment on attachment 394678 [details] [diff] [review] A patch to fix the missing variable warning [Checkin: Comment 5] though using let would be fine as well.
Updated•12 years ago
|
Attachment #394678 -
Flags: review?(bugmail) → review+
Comment 2•12 years ago
|
||
Comment on attachment 394678 [details] [diff] [review] A patch to fix the missing variable warning [Checkin: Comment 5] var is the safer bet here since 'i' is used outside of the for block.
Comment 3•12 years ago
|
||
ouch, yay for more context :-(
Assignee | ||
Comment 4•12 years ago
|
||
I don't know if it would have helped in this case, but I've since switched my mercurial diff options to: git = true showfunc = 1 unified = 8 as per https://developer.mozilla.org/en/Mercurial_FAQ#Configuration It makes the diffs look way bigger, but then again, that might not be so bad. Thanks, Blake.
Keywords: checkin-needed
Comment 5•12 years ago
|
||
Comment on attachment 394678 [details] [diff] [review] A patch to fix the missing variable warning [Checkin: Comment 5] http://hg.mozilla.org/comm-central/rev/d13680105f86
Attachment #394678 -
Attachment description: A patch to fix the missing variable warning. → A patch to fix the missing variable warning
[Checkin: Comment 5]
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b4
You need to log in
before you can comment on or make changes to this bug.
Description
•