510969 - clean up star-triggered "edit bookmark" dialog

Status: VERIFIED DUPLICATE of bug 514217

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

We currently re-use the same dialog for bookmark editing from the bookmark management UI and bookmark editing from the star popup. We should:

- remove "delete" and "move" from bookmark popup only (not from edit mode,
though that will need to be reworked a bit too)
- move buttons to the bottom (also not in edit mode)

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: patch

I'm doing that for now but i'll probably explode the binding for some work on bug 514217 :)

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

forgot the wince css change

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

hmmm, why the edit button in tthe bookmark list doesn't opened all the field to edit? Is it a design decision?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #3)
> hmmm, why the edit button in tthe bookmark list doesn't opened all the field to
> edit? Is it a design decision?

What do you mean? I see 3 editboxes (title, url and tags) when I press the edit button in the bookmark list

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #4)
> (In reply to comment #3)
> > hmmm, why the edit button in tthe bookmark list doesn't opened all the field to
> > edit? Is it a design decision?
> 
> What do you mean? I see 3 editboxes (title, url and tags) when I press the edit
> button in the bookmark list

I spoke about the bookmarks UI reachable through the 'See all bookmarks' button in the awesomebar results

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 399066 [details] [diff] [review]
Patch

This patch is made obsolete by the work i'm doing on bug 514217

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Fixed by bug 514217

Comment 8

[Aakash Desai [:aakashd]]

v dupe.