Closed
Bug 514217
Opened 15 years ago
Closed 15 years ago
Apply new awesomebar format/styling to bookmarks manager
Categories
(Firefox for Android Graveyard :: Bookmarks, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
fennec1.0b4
People
(Reporter: madhava, Assigned: vingtetun)
References
Details
(Whiteboard: [fennec l10n])
Attachments
(5 files, 2 obsolete files)
|
169.85 KB,
image/png
|
Details | |
|
54.18 KB,
image/png
|
madhava
:
ui-review+
|
Details |
|
50.93 KB,
image/png
|
madhava
:
ui-review+
|
Details |
|
17.30 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
|
51.51 KB,
image/png
|
madhava
:
ui-review+
|
Details |
explanatory diagram
A lot of formatting and styling has be applied to the awesomebar results set. Pretty much all of this is equally applicable to the bookmarks manager list. We should do the same there so that they seem more alike (and the bookmark manager just gets better). See attached diagram.
|
Reporter | |
Comment 1•15 years ago
|
||
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → 21
|
|
Assignee | |
Comment 2•15 years ago
|
||
Actually the manager button won't look pressed, we don't any 'classic' checkbox css theme :( Did i have missed something?
|
|
Assignee | |
Comment 3•15 years ago
|
||
Attachment #399236 -
Flags: ui-review?
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #399237 -
Flags: ui-review?
|
|
Assignee | |
Comment 5•15 years ago
|
||
Attachment #399239 -
Flags: ui-review?
|
|
Assignee | |
Updated•15 years ago
|
Attachment #399236 -
Flags: ui-review? → ui-review?(madhava)
|
|
Assignee | |
Updated•15 years ago
|
Attachment #399237 -
Flags: ui-review? → ui-review?(madhava)
|
|
Assignee | |
Updated•15 years ago
|
Attachment #399239 -
Flags: ui-review? → ui-review?(madhava)
|
|
Assignee | |
Comment 6•15 years ago
|
||
Attachment #399235 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•15 years ago
|
||
Attachment #399237 -
Attachment is obsolete: true
Attachment #399437 -
Flags: ui-review?(madhava)
Attachment #399237 -
Flags: ui-review?(madhava)
|
||
Updated•15 years ago
|
Whiteboard: [fennec l10n]
|
|
Reporter | |
Comment 8•15 years ago
|
||
Comment on attachment 399236 [details]
classic mode
there seems to be a bit more space between the favicon and title than between the favicon and the side of the screen, but this is still a huge improvement.
Attachment #399236 -
Flags: ui-review?(madhava) → ui-review+
|
|
Reporter | |
Updated•15 years ago
|
Attachment #399239 -
Flags: ui-review?(madhava) → ui-review+
|
|
Reporter | |
Updated•15 years ago
|
Attachment #399437 -
Flags: ui-review?(madhava) → ui-review+
|
|
||
Updated•15 years ago
|
Attachment #399436 -
Flags: review+
|
|
||
Comment 9•15 years ago
|
||
pushed: https://hg.mozilla.org/mobile-browser/rev/dc544417816a Looks great!
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → B4
|
||
Comment 11•15 years ago
|
||
This is going to affect a lot of our BFTs on litmus... otherwise, verified FIXED on builds: Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a2pre) Gecko/20090911 Fennec/1.0a3 and Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090911 Fennec/1.0a3 and Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2a2pre) Gecko/20090911 Fennec/1.0b4pre
Status: RESOLVED → VERIFIED
Flags: in-litmus?
|
|
||
Updated•14 years ago
|
Component: General → Bookmarks
|
|
||
Comment 12•14 years ago
|
||
Litmus testcases: https://litmus.mozilla.org/show_test.cgi?id=7640 https://litmus.mozilla.org/show_test.cgi?id=9848 https://litmus.mozilla.org/show_test.cgi?id=7245 https://litmus.mozilla.org/show_test.cgi?id=7635 test the major features of the bookmarks manager with the new styling.
Flags: in-litmus? → in-litmus+
|
||
Updated•11 years ago
|
tracking-fennec: ? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•