511181 - [mozmill] Test that the Larry UI opens and closes

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

This is a placeholder bug for writing a Mozmill test script for https://litmus.mozilla.org/show_test.cgi?id=6544

Comment 1

[u279076]

Attachment: Initial patch

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 395129 [details] [diff] [review]
Initial patch

Anthony, I have checked the test with a couple of negative tests and we fail in circum instances. Following changes I have made which i will upload as a follow-up patch shortly:

* We should follow the naming of elements in the browser. Using larry and doorhanger isn't the best choice.
* Using a global gDelay and gTimeout value
* We cannot check the class name in this case because we don't know which web page is open. If a page with a DV or EV cert is open the test fails. I changed it to check the visibility of the more info button. Further I made some updates to the assertElementVisible function which reports the correct info now.
* We should not use keypress to close the popup. We click outside of the popup now.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v2

Comment 4

[u279076]

>   controller.window.focus();

I understand you doing this to solve bullet point 3 from above.  However, I think a better way would be to open a particular web page (about:blank for example).  This way we can guarantee the state of the tab.  controller.window.focus() merely ensures focus on the window.  It does not change what page is loaded -- which is the problem as I understand it.

If you've tested this across all platforms multiple times and it works, I'll r+ this.

Comment 5

[u279076]

FWIW, it may make more sense to roll these tests into each of the GREEN, BLUE, and GREY tests I've already submitted for review (since the testing here is pretty minimal).

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #4)
> >   controller.window.focus();
> 
> I understand you doing this to solve bullet point 3 from above.  However, I

It's a left-over. We don't need it. Thanks for noticing it. Without the state check (which we already do in the other tests) it will work whichever page is open. The button is always there.

> If you've tested this across all platforms multiple times and it works, I'll r+
> this.

Sure. Works well.

(In reply to comment #5)
> FWIW, it may make more sense to roll these tests into each of the GREEN, BLUE,
> and GREY tests I've already submitted for review (since the testing here is
> pretty minimal).

It's a separate Litmus test so we should keep it independent. Otherwise we will have a problem with the reported result. And it's really quick. So it doesn't matter.

Comment 7

[Aakash Desai [:aakashd]]

Comment on attachment 395311 [details] [diff] [review]
Patch v2

Aye, I agree with Anthony's assessment. It's a better option to keep tests separated from each other unless they depend on each other or if there would be a 1-2 line extension of the testscript. This only works as long as the testscript's functionality and readability cannot be called into question. In this case, it's true. The testcase just wouldn't fit as well into the other testscript as opposed to its own. 

I've done a quick run with and without the controller.window.focus() and it works either way. Move forward :)

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as http://hg.mozilla.org/qa/mozmill-tests/rev/245fb8b43fed

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.