Closed
Bug 511775
Opened 17 years ago
Closed 17 years ago
Centralize browser-check regex and add Namoroka to supported UAs
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
5.0.9
People
(Reporter: fligtar, Assigned: wenzel)
Details
Attachments
(2 files)
|
3.35 KB,
patch
|
clouserw
:
review+
wenzel
:
review-
|
Details | Diff | Splinter Review |
|
4.55 KB,
patch
|
clouserw
:
review+
|
Details | Diff | Splinter Review |
We need a constant for this, wtf!
Attachment #395705 -
Flags: review?(clouserw)
Updated•17 years ago
|
Attachment #395705 -
Flags: review?(clouserw) → review+
| Reporter | ||
Comment 1•17 years ago
|
||
Comment 2•17 years ago
|
||
| Reporter | ||
Comment 3•17 years ago
|
||
Try a hard refresh of JS maybe? Or do we need to somehow manually update the JS bundle on preview?
Comment 4•17 years ago
|
||
(In reply to comment #3)
> Try a hard refresh of JS maybe? Or do we need to somehow manually update the JS
> bundle on preview?
I tried the former, of course; I think maybe it has to do something with our build script/future-expires headers (or lack thereof?) on JS/CSS files.
| Assignee | ||
Comment 5•17 years ago
|
||
There *is* a constant for this, on top of the amo2009/addons.js file. You patched a file that's not in use anymore :(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
| Assignee | ||
Comment 6•17 years ago
|
||
Comment on attachment 395705 [details] [diff] [review]
patch, v1
Now I do admit it's not consistently used yet, but maybe we should do that in this bug.
Attachment #395705 -
Flags: review-
| Assignee | ||
Updated•17 years ago
|
Summary: Add Namoroka to supported UAs → Centralize browser-check regex and add Namoroka to supported UAs
| Assignee | ||
Comment 9•17 years ago
|
||
This patch centralizes the browser check regexes in all "amo2009-compatible" locations.
Also, for the record, the advanced search UI code is quite hideous. Brrr.
| Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
| Assignee | ||
Updated•17 years ago
|
Attachment #395822 -
Flags: review?(clouserw)
Updated•17 years ago
|
Attachment #395822 -
Flags: review?(clouserw) → review+
| Assignee | ||
Comment 10•17 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Robert, mind testing SeaMonkey on preview.AMO with these changes?
(In reply to comment #11)
> Robert, mind testing SeaMonkey on preview.AMO with these changes?
Tested this myself, and filed bug 512340 (edge case?) as a result.
Verified FIXED.
Status: RESOLVED → VERIFIED
Comment 13•17 years ago
|
||
(In reply to comment #12)
> (In reply to comment #11)
> > Robert, mind testing SeaMonkey on preview.AMO with these changes?
>
> Tested this myself, and filed bug 512340 (edge case?) as a result.
Thanks for doing that, I'm currently running behind things somewhat and only slowly catching up - I read the request but couldn't get around to look into it yet.
Updated•17 years ago
|
Keywords: push-needed
Updated•10 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•