Closed Bug 511775 Opened 17 years ago Closed 17 years ago

Centralize browser-check regex and add Namoroka to supported UAs

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: fligtar, Assigned: wenzel)

Details

Attachments

(2 files)

Attached patch patch, v1 — — Splinter Review
We need a constant for this, wtf!
Attachment #395705 - Flags: review?(clouserw)
Attachment #395705 - Flags: review?(clouserw) → review+
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: push-needed
Resolution: --- → FIXED
Weird; preview should have this change, as it's at r49670, and this fix was r49655, but I still see "Download Now" buttons when using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a2pre) Gecko/20090820 Namoroka/3.6a2pre. I should be seeing "Add to Firefox", yeah?
Try a hard refresh of JS maybe? Or do we need to somehow manually update the JS bundle on preview?
(In reply to comment #3) > Try a hard refresh of JS maybe? Or do we need to somehow manually update the JS > bundle on preview? I tried the former, of course; I think maybe it has to do something with our build script/future-expires headers (or lack thereof?) on JS/CSS files.
There *is* a constant for this, on top of the amo2009/addons.js file. You patched a file that's not in use anymore :(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 395705 [details] [diff] [review] patch, v1 Now I do admit it's not consistently used yet, but maybe we should do that in this bug.
Attachment #395705 - Flags: review-
I'll fix it.
Assignee: fligtar → fwenzel
Status: REOPENED → NEW
Summary: Add Namoroka to supported UAs → Centralize browser-check regex and add Namoroka to supported UAs
Attached patch Patch, rev. 1 — — Splinter Review
This patch centralizes the browser check regexes in all "amo2009-compatible" locations. Also, for the record, the advanced search UI code is quite hideous. Brrr.
Status: NEW → ASSIGNED
Attachment #395822 - Flags: review?(clouserw)
Attachment #395822 - Flags: review?(clouserw) → review+
Status: ASSIGNED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Robert, mind testing SeaMonkey on preview.AMO with these changes?
(In reply to comment #11) > Robert, mind testing SeaMonkey on preview.AMO with these changes? Tested this myself, and filed bug 512340 (edge case?) as a result. Verified FIXED.
Status: RESOLVED → VERIFIED
(In reply to comment #12) > (In reply to comment #11) > > Robert, mind testing SeaMonkey on preview.AMO with these changes? > > Tested this myself, and filed bug 512340 (edge case?) as a result. Thanks for doing that, I'm currently running behind things somewhat and only slowly catching up - I read the request but couldn't get around to look into it yet.
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: