511864 - Switching to full screen causes the ugly white corner to be shown

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Steps:
1) Start up fennec
2) hit fullscreen button

you'll see the ugly white corner in the upper left corner.  The url bar should slide over to cover that.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: screen shot

Comment 2

[Ben Combee (:bcombee)]

I saw this too on my n810.

Comment 3

[Ben Combee (:bcombee)]

Attachment: Adjust rounding check in hideSidebars to work when switching to fullscreen

In debugging, I saw that the wrong case was being used here because the containing rect would have a left value of -0.13333 when going into full-screen mode.  This is fixed by rounding() early before the less-than-zero check.  The other change is to reduce the number of calls to bv.onAfterVisibleMove, since that's called inside hideSidebars.

Comment 4

[Ben Combee (:bcombee)]

This bug can be reproduced on desktop using F6 full-screen switching key.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 397287 [details] [diff] [review]
Adjust rounding check in hideSidebars to work when switching to fullscreen

>   sizeControls : function(windowW, windowH) {
>+    Util.dumpLn("*** sizeControls");
>     let tabs = document.getElementById("tabs-container");
I assume you'll get rid of the dump before pushing
 
>   isTabsVisible: function isTabsVisible() {
>-    let [leftvis,,,] = Browser.computeSidebarVisibility();
>+    let [leftvis,_1,_2,_3] = Browser.computeSidebarVisibility();
>     return (leftvis > 0.002);
>   },

I don't understand this, where do _1, _2 and _3 come from?

Comment 6

[Ben Combee (:bcombee)]

Yeah, I'll update patch removing that dumpLn.  I'm leaving in the _1,_2,_3 which works around a bug in js2-mode in emacs where it won't parse the file.  Hopefully this won't cause any performance issue due to the never-referred to variables.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mobile-browser/rev/73cfd4b0ca76

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090828 Fennec/1.0a3