511927 - [IE7][Timeplot] IE Javascript errors break all add-on statistics plots

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Statistics, defect, P4)

Description

[Scott McCammon [:mccammos]]

Attachment: Trailing commas fix

The attached patch fixes trailing commas in the source and json data. This gets the Summary, Downloads, and ADU plots working.

Add-on Version, Application, Add-on Status, and Operating System plots still fail with an uncaught exception:

Line: 387 (simile/amo-bundle.js)
Error: Exception thrown and not caught

Comment 1

[Scott McCammon [:mccammos]]

I will hold off on this patch, as switching from $listing->json() to $javascript->object() could have some subtle side effects.

More investigation and testing is needed.

Comment 2

[Wil Clouser [:clouserw]]

Comment on attachment 395883 [details] [diff] [review]
Trailing commas fix

thanks

Comment 3

[Scott McCammon [:mccammos]]

Attachment: Trailing commas fix, v2

A safer approach to v1: rather than abandon $listing->json(), this patch fixes it so that it no longer outputs trailing commas. IE gets a little bit of loving, with very little regression risk for everything else.

Test with: /statistics/json/{ADDON_ID}/summary

Comment 4

[Scott McCammon [:mccammos]]

Trailing commas fixed in r50589.

Timeplot still throws an exception when viewing any of the detailed ADU plots.

-> P4 at the most.