511952 - Hard coded "firefox" instances

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Paul Craciunoiu [:paulc]]

lib/googlelib.php:112
lib/import/htmlimportlib.php:119,121 (added in r9395)
tiki-view_forum_thread.php:353
forum_advanced_post.php:36 (this one will be tricky)

Comment 1

[Paul Craciunoiu [:paulc]]

Comments:
1. googlelib.php: I say we leave it.

2. htmlimportlib.php: This file is ONLY used in tiki-editpage.php. We should remove suck_locale functionality entirely from tiki-editpage.php

3. tiki-view_forum_thread.php: Move message into template.

4. forum_advanced_post.php: This file is only included if $_REQUEST["forum_advanced_post"] is set (in the template). However, if Fennec will use it, we can make this feature productizable as part of bug 505425. Should we move that to 1.3 then? Or have a separate bug to make it productizable?

Comment 2

[Paul Craciunoiu [:paulc]]

Attachment: html import removal

This removes the htmlimport functionality. I searched and removed all instances in .php or .tpl files. Fairly simple and straightforward.

Comment 3

[Paul Craciunoiu [:paulc]]

(In reply to comment #1)
> 3. tiki-view_forum_thread.php: Move message into template.
I will take care of this in bug 510282, repatching there.

Comment 4

[Paul Craciunoiu [:paulc]]

Laura: I'd like to wait to talk about this with you a bit, before comitting.

Comment 5

[Paul Craciunoiu [:paulc]]

Attachment: html import removal, v2

Missed some things. I did some investigation and we don't really use this feature, so yay! It is part of tiki, though:
http://www.google.com/search?q=feature_wiki_import_html&ie=utf-8&oe=utf-8&aq=t&rls=com.ubuntu:en-US:unofficial&client=firefox-a

Also, to clean up the DB, we should also run this SQL patch:
--------
DELETE FROM tiki_preferences WHERE name = 'feature_wiki_import_html';
--------
I can attach a file but it's just one line...

Comment 6

[Laura Thomson :laura]

Comment on attachment 396558 [details] [diff] [review]
html import removal, v2

Remember the SQL for the push bug!

Comment 7

[Paul Craciunoiu [:paulc]]

r50320-1 (forgot to remove webroot/lib/import on stage)
r50323

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

What's the best way to test this?

Comment 9

[Paul Craciunoiu [:paulc]]

I can't really think of one. We removed a feature that wasn't being used.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; haven't run into anything in my testing that I think is related to this.