Closed Bug 510282 Opened 12 years ago Closed 12 years ago

Hard coded SUMO-specific links to articles and error messages

Categories

(support.mozilla.org :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: paulc, Assigned: paulc)

References

Details

(Whiteboard: sumo_only)

Attachments

(1 file, 1 obsolete file)

We need to figure out a way to remove hard coded links to articles from the code. It's probably fine to keep them in the templates - since those are not going to be part of productization.

However, they can't be part of the main .php files.

Here's an instanec where they can be found in error messages:
http://viewvc.svn.mozilla.org/vc/projects/sumo/trunk/webroot/tiki-edit_translation.php?r1=12488&r2=13331
Other instances:
http://viewvc.svn.mozilla.org/vc/projects/sumo/trunk/webroot/tiki-editpage.php?r1=21927&r2=22012
http://viewvc.svn.mozilla.org/vc/projects/sumo/trunk/webroot/tiki-editpage.php?r1=11096&r2=13331
http://viewvc.svn.mozilla.org/vc/projects/sumo/trunk/webroot/tiki-editpage.php?r1=9859&r2=9866
The last one, especially, will require an admin pref of sorts for "friendly URLs"

At any rate, a new product site will break if not provided with similar htaccess rules to those we have on SUMO.

Here are examples of a hard coded product name in the error message of .php files:
http://viewvc.svn.mozilla.org/vc/projects/sumo/trunk/webroot/tiki-feedback.php?r1=20740&r2=23744
http://viewvc.svn.mozilla.org/vc/projects/sumo/trunk/tiki-forums_feedback_ajax.php?revision=19475&view=markup&pathrev=19475
Probably more to come as I audit.
Summary: Hard coded links to articles → Hard coded SUMO-specific links to articles and error messages
https://bugzilla.mozilla.org/show_bug.cgi?id=487175
Hard coded "Firefox user" bug
Attached patch patch, v1 (obsolete) — Splinter Review
Patch fixes:
- Hard coded "Firefox" text from: tiki-edit_translation.php, tiki_editpage.php, tiki-feedback.php and tiki-feedback_ajax.php
- Moves Firefox-specific error messages in the templates for instances in files above.

Took me a while, to find a good but simple way to do it.

Note that the following have been left unchanged as they will be fine for the Fennec release.
This requires htaccess set up and redirects would break without it:
http://viewvc.svn.mozilla.org/vc/projects/sumo/trunk/webroot/tiki-editpage.php?r1=9859&r2=9866
Proposed future solution: add a pref to turn on/off "friendly URLs." This may add to page load time, however.

This is from bug 488788:
http://viewvc.svn.mozilla.org/vc/projects/sumo/trunk/webroot/tiki-tc.php?r1=27982&r2=48092
I don't really have a proposed solution for this.

Laura: please take a look at these two and tell me what you think we should do.
Attachment #395695 - Flags: review?(laura)
Attached patch patch, v2Splinter Review
Updated with item 3 from bug 511952.
Attachment #395695 - Attachment is obsolete: true
Attachment #395695 - Flags: review?(laura)
Attachment #395942 - Flags: review?(laura)
Attachment #395942 - Flags: review?(laura) → review+
r49769 / r49770
Lots of QA needed. To test this, make sure all the files/errors listed in the revisions still show up right. All the functionality w.r.t. these changes should remain the same as on prod. If you need help testing, let me know.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
I looked through the filenames in the patch as a guideline for testing -- did my best, will call it verified FIXED.  Overall, seems to be working fine -- I'll be filing as I continue to test.
Status: RESOLVED → VERIFIED
Whiteboard: sumo_only
You need to log in before you can comment on or make changes to this bug.