511986 - Move minify's $config into a config file

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Paul Craciunoiu [:paulc]]

See webroot/minify.php

The js/css files are SUMO specific and should be moved into a config file that's not under SVN.

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

This is the SVN patch with adds the dist but not the actual conf. To set things up, copy over minify.conf.php.dist to the same location but without the .dist
I think scripts/minify is an appropriate location for this.

Comment 2

[Paul Craciunoiu [:paulc]]

r49764 / r49765

Comment 3

[Paul Craciunoiu [:paulc]]

Also filed bug 512010 to create the file on stage.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Because bug 512010 is verified, does that mean this one is too?

Comment 5

[Paul Craciunoiu [:paulc]]

Pretty much. If CSS or JS happens to be broken, you can reopen. If the config hadn't been set up well, we would have probably noticed by now.

If you look at the patch, I basically cut out the $config variable and pasted it in a separate file, so there's little chance of regression :)

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #5)
> Pretty much. If CSS or JS happens to be broken, you can reopen. If the config
> hadn't been set up well, we would have probably noticed by now.

Yes, agreed; it's been over the weekend, and things look fine.

> If you look at the patch, I basically cut out the $config variable and pasted
> it in a separate file, so there's little chance of regression :)

Verified FIXED -- if I see anything strange with JS or CSS I'll file.

Comment 7

[Louis-Philippe Huberdeau]

All configurations must be preferences in tiki, so no upstream.