512072 - Collections Extension: Thunderbird Toolbar Button

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect, P2)

Description

[Brian King [:kinger]]

Add-ons toolbar button for Thunderbird.

Theme and sizing fun may ensue.

Comment 1

[Brian King [:kinger]]

A functional button is now in, r49792.

On Mac there are 2 issues:

1. The regular size is 32x32, compared to 24x24 in Firefox.
2. The design does not match the theme.

Looking at the code, the regular size on Windows and Linux is 24x24. I have not tested there yet to review the themes.

Comment 2

[Brian King [:kinger]]

Attachment: Regular toolbar view on Mac

Note the Add-ons button mis-fit.

The small size is 24x24 so we can reuse that, unless we go with a different design for TB.

Comment 3

[Brian King [:kinger]]

-> Justin for 32x32 Mac icons, and possibly new designs for TB on some or all platforms.

Comment 4

[Brian King [:kinger]]

Attachment: Firefox toolbar composite, for reference

Comment 5

[Justin Scott [:fligtar]]

For Thunderbird, can we use the default extension icon? The icon that appears in the Add-ons Manager when the extension hasn't specified an icon.

It seems to go best with the Thunderbird style.

Comment 6

[Brian King [:kinger]]

r50954.

Comment 7

[Brian King [:kinger]]

Justin,

These are hooked up now. We cobbled together icons from a few different sets on each platform as the sizes states did not match exactly what we needed. They were from these locations.

http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/themes/pinstripe/mozapps/extensions/
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/themes/winstripe/mozapps/extensions/

I'm assigning over to you for inspection/approval. You'll notice, for example, the gnomestripe 24x24 has degraded a little in the process of down-scaling it.

Comment 8

[Brian King [:kinger]]

r50995 has more tweaks to co-ordinates on Windows and Linux.

TODO:
16x16 hover on XP and Aero

I forgot to mention, the files are in skin/images/tb/

Comment 9

[Justin Scott [:fligtar]]

I tried it out in Thunderbird and it looks/works great to me. I only tried on Mac, but the Windows icons seem fine from looking in the directory.

Thanks!

Comment 10

[Brian King [:kinger]]

(In reply to comment #9)
> I tried it out in Thunderbird and it looks/works great to me. I only tried on
> Mac, but the Windows icons seem fine from looking in the directory.

Ok, thanks.

(In reply to comment #8)
> TODO:
> 16x16 hover on XP and Aero

Keeping open for this issue.

Comment 11

[Brian King [:kinger]]

(In reply to comment #10)
> > TODO:
> > 16x16 hover on XP and Aero
> 
> Keeping open for this issue.

Done, r51206.