Last Comment Bug 512307 - Recognize and parse RFC 822 dates that use "Z" as a timezone
: Recognize and parse RFC 822 dates that use "Z" as a timezone
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: RSS Discovery and Preview (show other bugs)
: Trunk
: All All
: -- normal with 1 vote (vote)
: Firefox 11
Assigned To: Phil Ringnalda (:philor)
:
Mentors:
http://feeds.arstechnica.com/arstechn...
Depends on: 682781
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-24 13:12 PDT by Darren Kalck [:D-Kalck]
Modified: 2012-02-01 13:58 PST (History)
3 users (show)
mak77: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Perhaps excessive (2.39 KB, patch)
2011-11-20 23:00 PST, Phil Ringnalda (:philor)
no flags Details | Diff | Review
Much less (1.44 KB, patch)
2011-11-20 23:01 PST, Phil Ringnalda (:philor)
mak77: review+
Details | Diff | Review

Description Darren Kalck [:D-Kalck] 2009-08-24 13:12:42 PDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; fr; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; fr; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2

The date of some feeds is not displayed while the date is RFC 822.
For example, "Mon, 24 Aug 2009 19:15:00 Z" is RFC 822 compliant and is validated by feedvalidator.org, but it's not displayed when the feed is displayed whith Firefox

Reproducible: Always

Steps to Reproduce:
1. Open the Ars Technica feed given as a URL
Actual Results:  
The date is not displayed

Expected Results:  
The date yould be parsed and displayed
Comment 1 Tanner M. Young [:tmyoung] 2009-08-26 12:01:42 PDT
I get the same problem with Windows XP:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a2pre) Gecko/20090825 Namoroka/3.6a2pre (.NET CLR 3.5.30729) ID:20090825052618
Comment 2 Darren Kalck [:D-Kalck] 2010-10-19 05:55:37 PDT
Should I set Firefox or Toolkit as the Product ?
Comment 3 Phil Ringnalda (:philor) 2011-11-20 23:00:19 PST
Created attachment 575808 [details] [diff] [review]
Perhaps excessive

This version is maybe a little over the top, but it's what I was thinking in bug 677135 comment 9 when I was thinking about using this as documentation for how to massage dates.
Comment 4 Phil Ringnalda (:philor) 2011-11-20 23:01:59 PST
Created attachment 575809 [details] [diff] [review]
Much less

Less pedantic, probably more reasonable.
Comment 5 Marco Bonardo [::mak] 2011-11-22 07:34:53 PST
Comment on attachment 575809 [details] [diff] [review]
Much less

Review of attachment 575809 [details] [diff] [review]:
-----------------------------------------------------------------

The verbose approach is something you may be proud for the next 10 years, but then someone could make you sad doing a code cleanup.  Since I don't want you to be sad, I'll accept this simpler approach :p
Comment 6 Marco Bonardo [::mak] 2011-11-22 07:36:46 PST
Ah, please, just add a reference to bug 682781 in the comment.
Comment 8 Ed Morley [:emorley] 2011-12-04 07:19:13 PST
https://hg.mozilla.org/mozilla-central/rev/38d6d2ac55e7

Note You need to log in before you can comment on or make changes to this bug.