Closed Bug 512307 Opened 16 years ago Closed 14 years ago

Recognize and parse RFC 822 dates that use "Z" as a timezone

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 11

People

(Reporter: D-Kalck, Assigned: philor)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

Much less
1.44 KB, patch
mak
: review+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; fr; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; fr; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 The date of some feeds is not displayed while the date is RFC 822. For example, "Mon, 24 Aug 2009 19:15:00 Z" is RFC 822 compliant and is validated by feedvalidator.org, but it's not displayed when the feed is displayed whith Firefox Reproducible: Always Steps to Reproduce: 1. Open the Ars Technica feed given as a URL Actual Results: The date is not displayed Expected Results: The date yould be parsed and displayed
Version: unspecified → 3.5 Branch
I get the same problem with Windows XP: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a2pre) Gecko/20090825 Namoroka/3.6a2pre (.NET CLR 3.5.30729) ID:20090825052618
Status: UNCONFIRMED → NEW
Component: General → RSS Discovery and Preview
Ever confirmed: true
OS: Windows 7 → All
QA Contact: general → rss.preview
Hardware: x86 → All
Should I set Firefox or Toolkit as the Product ?
Depends on: 682781
Summary: RSS date (<pubDate>) parser is not compliant with RFC 822 → Recognize and parse RFC 822 dates that use "Z" as a timezone
Version: 3.5 Branch → Trunk
Attached patch Perhaps excessive (obsolete) — — Splinter Review
This version is maybe a little over the top, but it's what I was thinking in bug 677135 comment 9 when I was thinking about using this as documentation for how to massage dates.
Attachment #575808 - Flags: review?(mak77)
Attached patch Much less — — Splinter Review
Less pedantic, probably more reasonable.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #575809 - Flags: review?(mak77)
Comment on attachment 575809 [details] [diff] [review] Much less Review of attachment 575809 [details] [diff] [review]: ----------------------------------------------------------------- The verbose approach is something you may be proud for the next 10 years, but then someone could make you sad doing a code cleanup. Since I don't want you to be sad, I'll accept this simpler approach :p
Attachment #575809 - Flags: review?(mak77) → review+
Flags: in-testsuite+
Attachment #575808 - Attachment is obsolete: true
Attachment #575808 - Flags: review?(mak77)
Ah, please, just add a reference to bug 682781 in the comment.
https://hg.mozilla.org/mozilla-central/rev/38d6d2ac55e7
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: