512460 - icon fixes for account central (qute and gnomestripe)

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Andreas Nilsson (:andreasn)]

Attachment: patch for gnomestripe

If we're not going to have enough time for the bigger layout changes for account central in Bug 489999 in time for 3.0, we need to update the icons for qute and gnomestripe (pinstripe looks ok already).

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

Will get to this later when I'm on linux again

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 396430 [details] [diff] [review]
patch for gnomestripe

the new icons look good, thanks!

Comment 3

[Andreas Nilsson (:andreasn)]

Attachment: patch for Vista

Comment 4

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of vista patch in action

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 398106 [details] [diff] [review]
patch for Vista

these look good from the screenshot

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 396430 [details] [diff] [review]
patch for gnomestripe

 
> #SubscribeRSS label[chromedir="rtl"] {
>   background: url("chrome://messenger/skin/accountcentral/manage-rss.png") right no-repeat !important;
>-}
>\ No newline at end of file

r=mkmelin, with a newline please

Comment 7

[Andreas Nilsson (:andreasn)]

Attachment: gnomestripe patch with no newline at the end

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 399041 [details] [diff] [review]
gnomestripe patch with no newline at the end

Feel free to just mark the patch r+ when you get "r, with nits picked"! :)

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

both these should be ready for checkin

Comment 10

[Mark Banner (:standard8)]

Both patches checked in:

http://hg.mozilla.org/comm-central/rev/c6115e682ef2
http://hg.mozilla.org/comm-central/rev/f065ff57b1d5

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 398106 [details] [diff] [review]
patch for Vista

Oh and a=me for checkin during the freeze.

Comment 12

[Thomas Stache]

It looks to me as if the new icons are smaller than the previous ones (maybe 22/24px instead of 32px?), so the alignment between icons and text baseline is off (just look at attachment 398132 [details]).

(I know, don't comment on resolved bugs, but...)

Comment 13

[Bryan Clark (DevTools PM) [:clarkbw]]

Good catch Thomas. It seems like the top/bottom padding is the problem.

For each theme we're using padding where we should be using margin instead.  We just need a quick patch to swap from padding to margin for each theme and things will line up yet retain good spacing.

http://mxr.mozilla.org/comm-central/source/mail/themes/qute/mail/accountCentral.css#104
http://mxr.mozilla.org/comm-central/source/mail/themes/pinstripe/mail/accountCentral.css#119
http://mxr.mozilla.org/comm-central/source/mail/themes/gnomestripe/mail/accountCentral.css#104