Closed Bug 512460 Opened 14 years ago Closed 13 years ago

icon fixes for account central (qute and gnomestripe)

Categories

(Thunderbird :: General, defect)

All
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b4

People

(Reporter: andreasn, Assigned: andreasn)

Details

Attachments

(3 files, 1 obsolete file)

Attached patch patch for gnomestripe (obsolete) — Splinter Review
If we're not going to have enough time for the bigger layout changes for account central in Bug 489999 in time for 3.0, we need to update the icons for qute and gnomestripe (pinstripe looks ok already).
Attachment #396430 - Flags: ui-review?(clarkbw)
Assignee: nobody → nisses.mail
Status: NEW → ASSIGNED
Will get to this later when I'm on linux again
Attachment #396430 - Flags: ui-review?(clarkbw)
Attachment #396430 - Flags: ui-review+
Attachment #396430 - Flags: review?(mkmelin+mozilla)
Comment on attachment 396430 [details] [diff] [review]
patch for gnomestripe

the new icons look good, thanks!
Attached patch patch for VistaSplinter Review
Comment on attachment 398106 [details] [diff] [review]
patch for Vista

these look good from the screenshot
Attachment #398106 - Flags: ui-review+
Attachment #398106 - Flags: review?(philringnalda)
Comment on attachment 396430 [details] [diff] [review]
patch for gnomestripe

 
> #SubscribeRSS label[chromedir="rtl"] {
>   background: url("chrome://messenger/skin/accountcentral/manage-rss.png") right no-repeat !important;
>-}
>\ No newline at end of file

r=mkmelin, with a newline please
Attachment #396430 - Flags: review?(mkmelin+mozilla) → review+
Hardware: x86 → All
Target Milestone: --- → Thunderbird 3.0b4
Attachment #399041 - Flags: review?(mkmelin+mozilla)
Comment on attachment 399041 [details] [diff] [review]
gnomestripe patch with no newline at the end

Feel free to just mark the patch r+ when you get "r, with nits picked"! :)
Attachment #399041 - Flags: review?(mkmelin+mozilla) → review+
Attachment #398106 - Flags: review?(philringnalda) → review+
Attachment #396430 - Attachment is obsolete: true
both these should be ready for checkin
Keywords: checkin-needed
Both patches checked in:

http://hg.mozilla.org/comm-central/rev/c6115e682ef2
http://hg.mozilla.org/comm-central/rev/f065ff57b1d5
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Attachment #398106 - Flags: approval-thunderbird3+
Comment on attachment 398106 [details] [diff] [review]
patch for Vista

Oh and a=me for checkin during the freeze.
Attachment #399041 - Flags: approval-thunderbird3+
It looks to me as if the new icons are smaller than the previous ones (maybe 22/24px instead of 32px?), so the alignment between icons and text baseline is off (just look at attachment 398132 [details]).

(I know, don't comment on resolved bugs, but...)
Good catch Thomas. It seems like the top/bottom padding is the problem.

For each theme we're using padding where we should be using margin instead.  We just need a quick patch to swap from padding to margin for each theme and things will line up yet retain good spacing.

http://mxr.mozilla.org/comm-central/source/mail/themes/qute/mail/accountCentral.css#104
http://mxr.mozilla.org/comm-central/source/mail/themes/pinstripe/mail/accountCentral.css#119
http://mxr.mozilla.org/comm-central/source/mail/themes/gnomestripe/mail/accountCentral.css#104
You need to log in before you can comment on or make changes to this bug.