Closed Bug 512475 Opened 16 years ago Closed 15 years ago

Modal dialog needs a function to stop observing (threading manager)

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [lib])

At the moment the observing method of the modal dialog will run infinitely when no modal dialog is opened in a test. Even after the test has been finished we never stop observing. Having multiple tests which make use of those modal dialogs will add their own instance and we end up in a couple of those running observers. We should change the way how we detect modal dialogs and use the threading manager. That way we have a background thread we could stop via a function call like modalDialog.stop(). Given by bug 492136 a thread would even be helpful to give a better error reporting to the main Mozmill thread.
Summary: [shard module] Modal dialog needs a function to stop observing → [shard module] Modal dialog needs a function to stop observing (threading manager)
Component: Mozmill → Mozmill Tests
QA Contact: mozmill → mozmilltests
Summary: [shard module] Modal dialog needs a function to stop observing (threading manager) → Modal dialog needs a function to stop observing (threading manager)
Whiteboard: [shared module]
Move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Product: Testing → Mozilla QA
No longer blocks: 560820
Depends on: 560820
Fixed by my patch on bug 560820. There is now a .stop() method available.
Assignee: nobody → hskupin
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Component: Mozmill Tests → Mozmill Shared Modules
Component: Mozmill Shared Modules → Mozmill Tests
Whiteboard: [shared module] → [lib]
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.