Closed Bug 512548 Opened 10 years ago Closed 10 years ago

[Mac Classic] Use "pressed" look for toolbarbuttons when their menu is open

Categories

(SeaMonkey :: Themes, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

(Keywords: classic, fixed-seamonkey2.0)

Attachments

(1 file, 2 obsolete files)

This is the SeaMonkey version of bug 510808.
Attached patch Fix toolbarbuttons (obsolete) — Splinter Review
I hope you don't mind, but I couldn't resist fixing those whitespaces.
Attachment #396548 - Flags: review?(mnyromyr)
Target Milestone: --- → seamonkey2.0b2
Attachment #396548 - Flags: review?(mnyromyr) → review+
Attachment #396548 - Flags: superreview?(neil)
Comment on attachment 396548 [details] [diff] [review]
Fix toolbarbuttons

>-#printButton:hover:active {
>+#printButton:hover:active,
>+#printButton[open] {
All these changes look reasonable.


> toolbar[iconsize="small"] > toolbarpaletteitem > #back-button:hover:active,
>-toolbar[iconsize="small"] > #back-button:hover:active {
>+toolbar[iconsize="small"] > toolbarpaletteitem > #back-button[open],
>+toolbar[iconsize="small"] > #back-button:hover:active,
>+toolbar[iconsize="small"] > #back-button[open] {
But I don't understand all these changes, since you shouldn't be able to have an active, disabled or open toolbarpaletteitem child... (a toolbarpaletteitem is a dynamic node created during toolbar customisation)
Attached patch New version (obsolete) — Splinter Review
I reverted my changes that affects stuff in customizing mode - I also removed the disabled buttons style rules. Actually, it'd be nicer if they worked, but that feels like another bug.
Attachment #396548 - Attachment is obsolete: true
Attachment #397362 - Flags: superreview?(neil)
Attachment #396548 - Flags: superreview?(neil)
Filed bug 512548 for non-mac/Modern removal of the redundant style rules.
Attachment #397362 - Flags: superreview?(neil)
Comment on attachment 397362 [details] [diff] [review]
New version

I just realized that I forgot the help buttons...
Attachment #397362 - Attachment is obsolete: true
Attachment #397687 - Flags: superreview?(neil)
(In reply to comment #4)
> Filed bug 512548 for non-mac/Modern removal of the redundant style rules.

Erm, bug 513453.
Comment on attachment 397687 [details] [diff] [review]
Also fix helpOverlay.css

>+#help-back-button:not([disabled="true"])[open] {
This is incorrect for a number of reasons:
1. :not rules belong after other rules
2. #help-back-button[disabled="true"] naturally overrides #help-back-button[open] (but not #help-back-button:hover:active)
3. It's not possible to open disabled buttons
So the rule should just be for #help-back-button[open] (and similarly for the other buttons). sr=me with that fixed.
Attachment #397687 - Flags: superreview?(neil) → superreview+
JFTR: as discussed on irc, I'll keep the patch as is since (even though it sucks) not using the :not would mean that the preceeding :hover rule will be more specific.
You can at least put the :not at the end right?
Comment on attachment 397687 [details] [diff] [review]
Also fix helpOverlay.css

Additional mac look and feel enhancement + some css cleanup.
Attachment #397687 - Flags: approval-seamonkey2.0?
Attachment #397687 - Flags: approval-seamonkey2.0? → approval-seamonkey2.0+
http://hg.mozilla.org/comm-central/rev/c53d94c4ef0b (with comment #10 addressed).
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: seamonkey2.0b2 → seamonkey2.0
Adding fixed-seamonkey2.0 keyword so the queries for approved but not fixed bugs don't catch that bug.
Depends on: 537332
You need to log in before you can comment on or make changes to this bug.