512594 - Turn off building of SMIL on 1.9.2 branch

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

We'd rather have people testing the latest SMIL code, so we should encourage people that want to play with Mozilla's SMIL support to download nightlies. In general the type of person that's interested in playing with SMIL is probably sufficiently technically competent to do that.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jeff Schiller]

Kind of weird that Firefox 3.5 has the SMIL code included (with it pref'd to off) and Firefox 3.6 will not.

Comment 3

[Jonathan Watt [:jwatt]]

Firefox 3.5 doesn't have SMIL, Jeff.

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/1c843f224398

Comment 5

[Daniel Holbert [:dholbert]]

Somehow, this changeset didn't actually flip off SMIL in 1.9.2 builds -- it's still on in 3.6b2.

I just tested http://brian.sol1.net/svg/tests/accumulate.html in Firefox 3.6b2 (from the official beta download page) with the "svg.smil.enabled" pref flipped on, and it definitely animates.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2b2) Gecko/20091108 Firefox/3.6b2

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 396619 [details] [diff] [review]
patch

Quoting this bug's patch:
>diff --git a/configure.in b/configure.in
>+MOZ_SMIL=0
> MOZ_ARG_DISABLE_BOOL(smil,
>-[  --disable-smil           Disable SMIL animation support],
>-    MOZ_SMIL=,
>-    MOZ_SMIL=1 )
>+[  --enable-smil           Enable SMIL animation support],
>+    MOZ_SMIL=1,
>+    MOZ_SMIL= )
> # Automatically disable SMIL if SVG is disabled
> if test -z "$MOZ_SVG"; then
>   MOZ_SMIL=
> fi
> if test -n "$MOZ_SMIL"; then
>   AC_DEFINE(MOZ_SMIL)
> fi
> 

From comparing this to the patch that *enabled* SMIL in builds by default[1], I think the initial MOZ_SMIL=0 needs to be removed there.  The "test -n" check tests for non-zero string length, and the string "0" has nonzero length.

[1] https://bugzilla.mozilla.org/attachment.cgi?id=366476&action=diff

Comment 7

[Daniel Holbert [:dholbert]]

MOZ_ARG_DISABLE_BOOL also needs to be changed back to MOZ_ARG_ENABLE_BOOL.

Comment 8

[Daniel Holbert [:dholbert]]

Attachment: followup patch v1

This followup makes the changes I suggested in my last two comments.  Testing it locally before requesting review, to be absolutely sure it works.

Comment 9

[Daniel Holbert [:dholbert]]

Comment on attachment 411736 [details] [diff] [review]
followup patch v1

Confirmed locally that this followup patch works.
  - SMIL gets disabled in builds (even with svg.smil.enabled flipped on)
  - SMIL re-enabled (but still preffed off) I add --enable-smil to my mozconfig.

Comment 10

[Daniel Holbert [:dholbert]]

(In reply to comment #9)
>   - SMIL re-enabled (but still preffed off) I add --enable-smil to my
> mozconfig.

s/I add/if I add/

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 411736 [details] [diff] [review]
followup patch v1

I don't think this needs sr. land!

Comment 12

[Daniel Holbert [:dholbert]]

Landed: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/3fe53fb62d43

Comment 13

[Daniel Holbert [:dholbert]]

FWIW: as expected, this disabling gives us a bit of a codesize win. Here are the Zdiff measures for the first build after the push in comment 12, from http://tinderbox.mozilla.org/Firefox3.6/
 * Linux:    Zdiff:-54336 (+463/-54799)
 * Mac:      Zdiff:-73728 (+12422/-86150)
(Those are the only tinderbox columns that show Zdiff metrics, AFAICT)