Turn off building of SMIL on 1.9.2 branch

RESOLVED FIXED in mozilla1.9.2b1

Status

()

Core
SVG
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

1.9.2 Branch
mozilla1.9.2b1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(2 attachments)

We'd rather have people testing the latest SMIL code, so we should encourage people that want to play with Mozilla's SMIL support to download nightlies. In general the type of person that's interested in playing with SMIL is probably sufficiently technically competent to do that.
Created attachment 396619 [details] [diff] [review]
patch
Assignee: nobody → jwatt
Attachment #396619 - Flags: superreview?(roc)
Attachment #396619 - Flags: review?(roc)
Attachment #396619 - Flags: superreview?(roc)
Attachment #396619 - Flags: superreview+
Attachment #396619 - Flags: review?(roc)
Attachment #396619 - Flags: review+
(Assignee)

Updated

9 years ago
Attachment #396619 - Flags: approval1.9.2?

Comment 2

9 years ago
Kind of weird that Firefox 3.5 has the SMIL code included (with it pref'd to off) and Firefox 3.6 will not.
Firefox 3.5 doesn't have SMIL, Jeff.
Attachment #396619 - Flags: approval1.9.2? → approval1.9.2+

Updated

9 years ago
Keywords: checkin-needed
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/1c843f224398
Status: NEW → RESOLVED
Last Resolved: 9 years ago
status1.9.2: --- → beta1-fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2b1
Version: unspecified → 1.9.2 Branch
Somehow, this changeset didn't actually flip off SMIL in 1.9.2 builds -- it's still on in 3.6b2.

I just tested http://brian.sol1.net/svg/tests/accumulate.html in Firefox 3.6b2 (from the official beta download page) with the "svg.smil.enabled" pref flipped on, and it definitely animates.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2b2) Gecko/20091108 Firefox/3.6b2
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 396619 [details] [diff] [review]
patch

Quoting this bug's patch:
>diff --git a/configure.in b/configure.in
>+MOZ_SMIL=0
> MOZ_ARG_DISABLE_BOOL(smil,
>-[  --disable-smil           Disable SMIL animation support],
>-    MOZ_SMIL=,
>-    MOZ_SMIL=1 )
>+[  --enable-smil           Enable SMIL animation support],
>+    MOZ_SMIL=1,
>+    MOZ_SMIL= )
> # Automatically disable SMIL if SVG is disabled
> if test -z "$MOZ_SVG"; then
>   MOZ_SMIL=
> fi
> if test -n "$MOZ_SMIL"; then
>   AC_DEFINE(MOZ_SMIL)
> fi
> 

From comparing this to the patch that *enabled* SMIL in builds by default[1], I think the initial MOZ_SMIL=0 needs to be removed there.  The "test -n" check tests for non-zero string length, and the string "0" has nonzero length.

[1] https://bugzilla.mozilla.org/attachment.cgi?id=366476&action=diff
MOZ_ARG_DISABLE_BOOL also needs to be changed back to MOZ_ARG_ENABLE_BOOL.
Created attachment 411736 [details] [diff] [review]
followup patch v1

This followup makes the changes I suggested in my last two comments.  Testing it locally before requesting review, to be absolutely sure it works.
Comment on attachment 411736 [details] [diff] [review]
followup patch v1

Confirmed locally that this followup patch works.
  - SMIL gets disabled in builds (even with svg.smil.enabled flipped on)
  - SMIL re-enabled (but still preffed off) I add --enable-smil to my mozconfig.
Attachment #411736 - Flags: superreview?(roc)
Attachment #411736 - Flags: review?(roc)
Attachment #411736 - Flags: approval1.9.2?
(In reply to comment #9)
>   - SMIL re-enabled (but still preffed off) I add --enable-smil to my
> mozconfig.

s/I add/if I add/
Comment on attachment 411736 [details] [diff] [review]
followup patch v1

I don't think this needs sr. land!
Attachment #411736 - Flags: superreview?(roc)
Attachment #411736 - Flags: review?(roc)
Attachment #411736 - Flags: review+
Attachment #411736 - Flags: approval1.9.2?
Attachment #411736 - Flags: approval1.9.2+
Landed: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/3fe53fb62d43
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago8 years ago
Resolution: --- → FIXED
FWIW: as expected, this disabling gives us a bit of a codesize win. Here are the Zdiff measures for the first build after the push in comment 12, from http://tinderbox.mozilla.org/Firefox3.6/
 * Linux:    Zdiff:-54336 (+463/-54799)
 * Mac:      Zdiff:-73728 (+12422/-86150)
(Those are the only tinderbox columns that show Zdiff metrics, AFAICT)
Depends on: 473705
You need to log in before you can comment on or make changes to this bug.