541203 - Port |Bug 216462 - (smil) Implement SVG (SMIL) Animation| to comm-central, configure part

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Serge Gautherie (:sgautherie)]

History:
{
Firefox:
Bug 216462 added this feature to m-c (= m-1.9.2).
Bug 473705 enabled it on m-c (= m-1.9.2).
Bug 512594 disabled it on m-1.9.2 only.
NB: The default is then _OFF on m-1.9.2_ and ON on m-c.

SeaMonkey:
Bug 479297 added SM packaging part only to c-c (= c-1.9.1, but that's fine).
Bug 495612 did a s/MOZ_SMIL/!MOZILLA_1_9_1_BRANCH/g on the SM packaging part.
Bug 523820 removed m-1.9.1 SM case.

Thunderbird:
changeset 2349:ea9a98fbd162 added TB packaging part only with !MOZILLA_1_9_1_BRANCH.
Bug 530010 did a s/!MOZILLA_1_9_1_BRANCH/!MOZILLA_1_9_2_BRANCH/g on the TB packaging part.
}

Bug 479297 had a patch to do this (too), which was "wrongly" obsoleted after bug 495612 "wrongly" replaced of the MOZ_SMIL checks.

The usual way is to port the m-* configure setup, even if we will use it for packaging checks only.
KaiRo, do you actually want to use MOZILLA_1_9_2_BRANCH checks only (in this case)? Or should we restore/complete the MOZ_SMIL variable handling?

Comment 1

[Robert Kaiser]

(In reply to comment #0)
> KaiRo, do you actually want to use MOZILLA_1_9_2_BRANCH checks only (in this
> case)? Or should we restore/complete the MOZ_SMIL variable handling?

As Mozilla trees are using the MOZ_SMIL var, I think we should as well, and just set the default differently depending on the branch.

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Restore/complete MOZ_SMIL variable handling

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 422870 [details] [diff] [review]
(Av1) Restore/complete MOZ_SMIL variable handling

Mark, for the /mail/ file only.

Comment 4

[Robert Kaiser]

Comment on attachment 422870 [details] [diff] [review]
(Av1) Restore/complete MOZ_SMIL variable handling

Nah, let's just leave out those changes and for SeaMonkey's sake assume that
the defaults of the relevant Mozilla branch apply to all our builds.
As long as there is no known good use case of SeaMonkey with turning those
SVG/SMIL defaults to non-defaults, I think we should ignore them.

So, let's do the packaging changes with just branch ifdefs, I guess that's the best way to go.

Comment 5

[Robert Kaiser]

Comment on attachment 422870 [details] [diff] [review]
(Av1) Restore/complete MOZ_SMIL variable handling

Erm, meant to minus it, sorry.

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 422870 [details] [diff] [review]
(Av1) Restore/complete MOZ_SMIL variable handling

serge per kairo can we get this updated for suite/ only packaging with a 1_9_2 ifdef.

You can r? me based on his comment and my agreement that the larger SMIL port is not needed.

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)

I prefer to resolve bug 541267 before getting back to here.

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) Restore/complete MOZ_SMIL variable handling

Av1, updated after bug 541267.

KaiRo's p-o-v changed a little between comment 1 and comment 4.
Nontheless, I still think it's better to just copy what m-c has in this case;
as doing otherwise would instead need to explicitly unsupport the --*able-smil options...

Comment 9

[Robert Kaiser]

Comment on attachment 425003 [details] [diff] [review]
(Av2) Restore/complete MOZ_SMIL variable handling

r- for now for the simple reason that bug 521523 obsoletes the suite/ parts.
The rest looks good for me.

Comment 10

[Serge Gautherie (:sgautherie)]

Attachment: (Av3) Restore/complete MOZ_SMIL variable handling [Checkin: Comment 11]

Av1, un-bitrotted after bug 521523.

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 425912 [details] [diff] [review]
(Av3) Restore/complete MOZ_SMIL variable handling
[Checkin: Comment 11]


http://hg.mozilla.org/comm-central/rev/4c64fa59e01c