512828 - add a cmd_viewAllHeader and cmd_viewNormalHeader to the MessageWindowController

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Joachim Herb]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.9.1.1) Gecko/20090715 Thunderbird/3.0b3

If a copy of the menu id="viewheadersmenu" should be added to another place, e.g. through a addon as described in http://forums.mozillazine.org/viewtopic.php?f=29&t=1405155&p=7359805#p7359805 the internal handling has to be copied also to a new function. The reason for this is that the function InitViewHeadersMenu() uses the id of the menuitems in hard coded from. See:
http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.xul#1105
http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.js#401

The menu entries for "Add Star" and Tagging are initialized with functions (InitMessageMark(), InitMessageTags(this)) which dynamically update the menu check property.

Why not add a cmd_viewAllHeader and cmd_viewNormalHeader to the MessageWindowController in http://mxr.mozilla.org/comm-central/source/mail/base/content/messageWindow.js#679 

Then this infrastructure could be used also for toggling the header view.

Reproducible: Always

Comment 1

[Magnus Melin [:mkmelin]]

herb: can you make a patch for that?

Comment 2

[Joachim Herb]

Attachment: Change internal handling of All Header / Normal Header

I changed the internal handling following the example of the "Add Star" menu item.

Comment 3

[Magnus Melin [:mkmelin]]

Thx for the patch! For future reference, please make sure to flag the patch for review. Else its easily left sitting in bugzilla.
http://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree

I'll take a look at this later.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 397356 [details] [diff] [review]
Change internal handling of All Header / Normal Header

Mozilla code style is "no tabs!", besides that looks good, thx!

I also adjusted the patch not to use magic numbers.

Comment 5

[Magnus Melin [:mkmelin]]

changeset:   3571:b95b20eded49
http://hg.mozilla.org/comm-central/rev/b95b20eded49

->FIXED

If you have other stuff that's making it hard to develop extensions, do feel free to submit a patch for it!