512843 - add about:fennec page to include more links/different styling

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

See mockup in bug 509860 (attachment 393932 [details]).

Comment 1

[:Gavin Sharp [email: [e-mail]]]

I think we want to do this as an override of the existing about.xhtml (reached via "about:").

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: add about:fennec

I realized we can't really just override about.xhtml, because about: is unprivileged by default. So this patch adds an about:fennec that is privileged.

That led to reworking the firstrun redirector to also support "fennec", and I added the "rights" redirector while I was at it. The rights part still depends on bug 513023 to work.

There are a few issues with this still (marked by XXX comments), the links on the page don't all lead to useful places, and the styling is far from final, but I want to get this in as-is for the strings.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(ignore the changes to installer/Makefile.in, obviously!)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 398416 [details] [diff] [review]
add about:fennec

>diff --git a/app/mobile.js b/app/mobile.js

>+pref("app.releaseNotesURL", "http://www.mozilla.com/%LOCALE%/%APP%/%VERSION%/releasenotes/");
>+pref("app.support.baseURL", "http://support.mozilla.com/1/%APP%/%VERSION%/%OS%/%LOCALE%/");

can we use "app.release.notesURL" ?


>diff --git a/components/aboutFirstrun.js b/components/aboutRedirector.js

>+function aboutFirstrun() {}

Can we use a leading capital, like AboutGeneric?
AboutFirstrun, AboutFennec, AboutRights

>diff --git a/installer/Makefile.in b/installer/Makefile.in
>-	@rm -rf $(LIBXUL_DIST)/xulrunner*
>-	@$(MAKE) -C $(LIBXUL_DIST)/.. package || echo "Perhaps you're trying to package a prebuilt SDK. See 'https://wiki.mozilla.org/Mobile/Build/Fennec#Build' for more information."
>-	@cd $(DIST)/$(MOZ_PKG_DIR); $(UNMAKE_PACKAGE)
>+#	@rm -rf $(LIBXUL_DIST)/xulrunner*
>+#	@$(MAKE) -C $(LIBXUL_DIST)/.. package || echo "Perhaps you're trying to package a prebuilt SDK. See 'https://wiki.mozilla.org/Mobile/Build/Fennec#Build' for more information."
>+#	@cd $(DIST)/$(MOZ_PKG_DIR); $(UNMAKE_PACKAGE)

Don't land this. In fact, this should be fixed now.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> can we use "app.release.notesURL" ?

I used the same prefs as Firefox for these, so I'll leave it as is.

> Can we use a leading capital, like AboutGeneric?
> AboutFirstrun, AboutFennec, AboutRights

done

Comment 6

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mobile-browser/rev/7d88b0bea7fe

Filed followups:
bug 514464
bug 514467

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

about: looks the same in 20090910 1.9.2 nightly build on my n810.  We have an about:firefox which has all this stuff, but I thought in this bug we were fixing about:.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

We're not going to be changing about: after all. The page is currently at about:fennec (will probably move to about:firefox).

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

ok, verified with build 200909914 nightly trunk of 1.9.2 for n810 maemo

Comment 10

[Aakash Desai [:aakashd]]

There should be a BFT subgroup for about: pages as there's a number of them for fennec. Let's keep this going with about:fennec, about:firefox, about:, about:certerror, about:buildconfig and any others I'm forgetting at the moment.

Each testcase should test the content of what is shown on that page.

Comment 11

[Aakash Desai [:aakashd]]

Test case https://litmus.mozilla.org/show_test.cgi?id=9760 has been created on litmus to test this page.