Closed
Bug 512916
Opened 15 years ago
Closed 15 years ago
Split out mailTabType into its own file.
Categories
(Thunderbird :: Toolbars and Tabs, defect)
Thunderbird
Toolbars and Tabs
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0rc1
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
134.40 KB,
patch
|
asuth
:
review+
standard8
:
approval-thunderbird3+
|
Details | Diff | Splinter Review |
Based on the discussion in bug 500506 it appears that mailWindowOverlay.js and therefore mailTabType is loaded into many of our windows (hiddenWindow, searchDialog, standalone message window). This is unnecessary considering we just need it in the 3 pane window.
We should split it out into its own file where a) we can easily find it, b) it doesn't get unnecessarily loaded into those other windows.
SeaMonkey has gone with tabmail.js - I think we could go for the same, unless we wanted something like mailTabType.js.
Comment 1•15 years ago
|
||
I vote for mailTabs.js. For the revised faceted search I have gone with glodaFacetTab.js, which is mimicking specialTabs.js. Since mailTabType actually includes multiple tab varieties, mailTabs seems the most appropriate.
Assignee | ||
Comment 2•15 years ago
|
||
This copies out mailTabType to mailTabs.js so that we don't need to include it in most windows. I guess there is more that we can move or reorganise, but this will do for starters.
Attachment #401096 -
Flags: review?(bugmail)
Comment 3•15 years ago
|
||
Comment on attachment 401096 [details] [diff] [review]
The fix
let's land this quick to avoid drift
Attachment #401096 -
Flags: review?(bugmail) → review+
Assignee | ||
Updated•15 years ago
|
Attachment #401096 -
Flags: approval-thunderbird3+
Assignee | ||
Comment 4•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0rc1
You need to log in
before you can comment on or make changes to this bug.
Description
•