512994 - Deleting / recreating the updates/0 directory puts the filesystem into a weird state

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P1)

Description

[Robert Strong (they/them - no direct email)]

I've seen this happen a lot in emulators and also on the Tegra. When the dir is deleted and immediately recreated the dir can't be opened or deleted without restarting the OS.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

There doesn't seem to be a good reason to do this on any platform.

Comment 2

[Robert Strong (they/them - no direct email)]

(In reply to comment #1)
> Created an attachment (id=397023) [details]
> patch rev1
> 
> There doesn't seem to be a good reason to do this on any platform.
There doesn't seem to be a good reason NOT to do this on all platforms.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #1)
> There doesn't seem to be a good reason to do this on any platform.

Please excuse the hand wavyness, but is the handling of status files, mar's, etc robust enough that we'll be OK without wiping updates/0 frequently ?

Comment 4

[Robert Strong (they/them - no direct email)]

We already enumerate the files in the dir and delete them one by one with the exception of the last update log which was copied (now moved) to the parent dir. If we have trouble deleting them individually we'll have trouble deleting the directory as well.

Comment 5

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/06b5fd4ebee8

along with tests
http://hg.mozilla.org/mozilla-central/rev/10119fe2af2b

Comment 6

[[e-mail]]

Unrelated to NT ghosting a deleted directory until all its handles are closed?

Comment 7

[Robert Strong (they/them - no direct email)]

Likely something along those lines. I found that exiting Firefox on the Tegra or exiting Fennec on an emulator didn't fix it and the OS had to be restarted. I talked with dougt about it and filed bug 513051 to try to find the underlying issue.

Comment 8

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-1.9.2
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/33981af4e914

along with tests
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/d37939b149f0