Closed
Bug 512651
Opened 16 years ago
Closed 16 years ago
lessen the write access checks during startup and remove final-ui-startup observer
Categories
(Toolkit :: Application Update, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta2-fixed |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
(Whiteboard: [ts])
Attachments
(1 file, 5 obsolete files)
16.54 KB,
patch
|
robert.strong.bugs
:
review+
beltzner
:
approval1.9.2+
|
Details | Diff | Splinter Review |
I believe this was initially coded this way for simplicity and this can at the very least be improved.
![]() |
Assignee | |
Comment 1•16 years ago
|
||
Note: this may need to leverage bug 512650
Updated•16 years ago
|
Whiteboard: [ts]
![]() |
Assignee | |
Comment 2•16 years ago
|
||
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
![]() |
Assignee | |
Comment 3•16 years ago
|
||
Bug 512994 removes one of the deletions so adding dependency
Depends on: 512994
![]() |
Assignee | |
Comment 4•16 years ago
|
||
Attachment #396886 -
Attachment is obsolete: true
![]() |
Assignee | |
Comment 5•16 years ago
|
||
Bug 512994 makes it so we don't delete / recreate the updates/0 directory on startup so updating summary.
Summary: lessen the deletions / recreations of the updates and updates/0 directories during startup → lessen the write access checks during startup
![]() |
Assignee | |
Comment 6•16 years ago
|
||
Attachment #398823 -
Attachment is obsolete: true
![]() |
Assignee | |
Comment 7•16 years ago
|
||
Attachment #405102 -
Attachment is obsolete: true
![]() |
Assignee | |
Comment 8•16 years ago
|
||
I'm going to remove the workaround for bug 497578 which is fixed by bug 496335 so adding dependency.
Depends on: 496335
![]() |
Assignee | |
Updated•16 years ago
|
Summary: lessen the write access checks during startup → lessen the write access checks during startup and remove final-ui-startup observer
![]() |
Assignee | |
Comment 9•16 years ago
|
||
Attachment #405137 -
Attachment is obsolete: true
Attachment #405151 -
Flags: review?(dtownsend)
![]() |
Assignee | |
Comment 10•16 years ago
|
||
Dave, I just noticed that the following is not used so I'd like to remove it at the same time as I check this in
/**
* Gets a File URL spec for a nsIFile
* @param file
* The file to get a file URL spec to
* @returns The file URL spec to the file
*/
function getURLSpecFromFile(file) {
var ioServ = Cc["@mozilla.org/network/io-service;1"].
getService(Ci.nsIIOService);
var fph = ioServ.getProtocolHandler("file").
QueryInterface(Ci.nsIFileProtocolHandler);
return fph.getURLSpecFromFile(file);
}
![]() |
Assignee | |
Comment 11•16 years ago
|
||
Per bug 311965 comment #42 it looks like this will reduce nsUpdateService.js TS by about 70ms on Maemo.
from 10/8 with this patch and the patch from Bug 520526 applied
nsUpdateService.js : 78+2+7+2+30 = 119
from 10/2
nsUpdateService.js : 138+2+6+9+33 = 188ms
from 7/21
nsUpdateService.js : 109+2+28+36+25 = 200ms
Blocks: 459117
Updated•16 years ago
|
Attachment #405151 -
Flags: review?(dtownsend) → review+
![]() |
Assignee | |
Comment 12•16 years ago
|
||
Attachment #405151 -
Attachment is obsolete: true
Attachment #405559 -
Flags: review+
![]() |
Assignee | |
Comment 13•16 years ago
|
||
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/64e1e88b4d77
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
![]() |
Assignee | |
Comment 14•16 years ago
|
||
Drivers, according to Taras' logs this reduces TS on Maemo from somewhere between 45ms and 65ms so requesting blocking.
Flags: blocking1.9.2?
Priority: -- → P2
![]() |
Assignee | |
Comment 15•16 years ago
|
||
Comment on attachment 405559 [details] [diff] [review]
patch as checked in
Drivers, this has baked for a while now and improves TS at least on Fennec and possibly around .5% on desktop.
Attachment #405559 -
Flags: approval1.9.2?
![]() |
Assignee | |
Updated•16 years ago
|
Flags: blocking1.9.2?
Comment 16•16 years ago
|
||
Comment on attachment 405559 [details] [diff] [review]
patch as checked in
a191=beltzner
Attachment #405559 -
Flags: approval1.9.2? → approval1.9.2+
Comment 17•16 years ago
|
||
er, a192
![]() |
Assignee | |
Comment 18•16 years ago
|
||
Pushed to mozilla-1.9.2 - forgot to add the a=beltzner in the comment :(
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b9c0c7338779
status1.9.2:
--- → final-fixed
Updated•16 years ago
|
Flags: in-testsuite+
Target Milestone: --- → mozilla1.9.3a1
Version: unspecified → 1.9.2 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•