Closed Bug 513156 Opened 12 years ago Closed 12 years ago

Update Canvas3D to implement WebGL

Categories

(Core :: Canvas: 2D, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: mwsteele, Unassigned)

References

Details

Attachments

(2 files, 3 obsolete files)

Attached patch canvas3d->webgl, incomplete (obsolete) — Splinter Review
No description provided.
Attached patch delta to vlad's WIP patch (obsolete) — Splinter Review
Comment on attachment 397199 [details] [diff] [review]
delta to vlad's WIP patch

This looks fine to me -- implementing base functionality for the array types and the big renaming.

Mark, have you tested this on anything other than OSX?  Would be nice to have OSX and Win32 initially.

Are you ok with me landing this tonight/this weekend?
Attachment #397199 - Flags: review+
I updated it to build on Linux too, but haven't tried on Win32 recently.
I'm ok with it landing. Better to base new stuff off this than keep the big patch growing.

(In reply to comment #2)
> (From update of attachment 397199 [details] [diff] [review])
> This looks fine to me -- implementing base functionality for the array types
> and the big renaming.
> 
> Mark, have you tested this on anything other than OSX?  Would be nice to have
> OSX and Win32 initially.
> 
> Are you ok with me landing this tonight/this weekend?
Small changes to fix win32 build.
Also disabled buffer validation in drawElements for now.
Attachment #397182 - Attachment is obsolete: true
Attachment #397199 - Attachment is obsolete: true
Attachment #397583 - Flags: review?(vladimir)
Comment on attachment 397583 [details] [diff] [review]
delta with win32 fixes

Working on checking this in now.
Attachment #397583 - Flags: review?(vladimir) → review+
http://hg.mozilla.org/mozilla-central/rev/1438b43ad6e8

Hm.. let's close off this initial bug and then do individual bugs for followup patches, based on specific spec fixes/changes.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Version: unspecified → Trunk
Attached patch VC7.1 bustage fix (obsolete) — Splinter Review
Attachment #398611 - Flags: review?(vladimir)
Attachment #398611 - Attachment is obsolete: true
Attachment #398627 - Flags: review?(vladimir)
Attachment #398611 - Flags: review?(vladimir)
Comment on attachment 398627 [details] [diff] [review]
Corrected bustage fix

Upgrade your compiler :)
Attachment #398627 - Flags: review?(vladimir) → review+
Sure, but Microsoft charges to upgrade my optimiser :-P
Depends on: 517437
Depends on: 518894
Depends on: 520134
Depends on: 520708
Depends on: 520920
Depends on: 526423
Depends on: 542930
Depends on: 565393
You need to log in before you can comment on or make changes to this bug.