520920 - Update WebGL arrays to support views

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Comment 1

[Mark Steele]

Attachment: add CanvasArrayBuffer; make Canvas*Arrays views

still missing:
- offset/length ctor&set calls
- array copy ctors
- slice

Comment 2

[Joe Drew (not getting mail)]

Comment on attachment 404973 [details] [diff] [review]
add CanvasArrayBuffer; make Canvas*Arrays views

>+            if (NS_FAILED(rv) || !canvasObj) {
>+            //    nsCOMPtr<nsICanvasArrayBuffer> arrayBuf = do_QueryInterface(canvasObj, &rv); 
>+                fprintf(stderr, "new CanvasFloatArray from CanvasFloatArray\n");
>+                return NS_ERROR_DOM_SYNTAX_ERR;

Remove debugging code? (same idiom in each array type)


>diff -r 385f917b3cf9 layout/build/nsLayoutModule.cpp
>--- a/layout/build/nsLayoutModule.cpp	Sun Sep 20 00:12:48 2009 +1200
>+++ b/layout/build/nsLayoutModule.cpp	Tue Oct 06 20:15:13 2009 -0400
>@@ -1071,6 +1071,11 @@
>     NS_CANVASRENDERINGCONTEXTWEBGL_CID,
>     "@mozilla.org/content/canvas-rendering-context;1?id=moz-webgl",
>     CreateCanvasRenderingContextWebGL },
>+  { "Canvas WebGL Rendering Context",
>+    NS_CANVASRENDERINGCONTEXTWEBGL_CID,
>+    "@mozilla.org/content/canvas-rendering-context;1?id=experimental-webgl",
>+    CreateCanvasRenderingContextWebGL },

Should we enable experimental-webgl now? Are there any things that we don't support or that we support under different names?

Comment 3

[Mark Steele]

Attachment: offsets & slice; some fixes

Comment 4

[Mark Steele]

Attachment: standalone array tests

Comment 5

[Mark Steele]

Attachment: add array get/set

Comment 6

[Mark Steele]

Attachment: add invalid buffer size test

Comment 7

[Mark Steele]

Attachment: check for invalid buffer size, clean up casting

Comment 8

[Mark Steele]

Attachment: add interface to get WebGLArrayBuffer instance

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 407719 [details] [diff] [review]
add interface to get WebGLArrayBuffer instance

Looks fine, but get rid of the invalid WrapJS calls in the blocks that return NOT_IMPLEMENTED; just have the NS_FAILED/!canvasObj block return a syntax error.

Comment 10

[Mark Steele]

Attachment: updated per comment

Comment 11

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: part 2, on top of the previous patch

Patch on top of the previous patch, that fixes some bugs and moves some stuff around.

Comment 12

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: part 2 again, now with added files

Forgot to add new files.

Comment 13

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

http://hg.mozilla.org/mozilla-central/rev/a2dc7d54c77c