513212 - Allow people to set "See Also" when filing/creating/entering a bug on enter_bug.cgi or the Bug.create webservice

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Csilla Deák Gáborné]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; hu; rv:1.9.0.13) Gecko/2009073022 Firefox/3.0.13 (.NET CLR 3.5.30729)
Build Identifier: 3.4.1 Release

Please put the See also field to the Advanced Field view of bug entering screen.

Reproducible: Always

Comment 2

[Thomas D. (:thomas8)]

Forwarding Importance C3 set by mkanat from duplicate bug 530024.

Comments from duplicate bug 530024:
> When I submitted a bug to Mozilla, I couldn't add the launchpad link with
> Advanced fields turned on.
> ---
> Frédéric Buclin: Hum right, See Also is not displayed in enter_bug.cgi, for
> some reason.
> ---
> As a bug triager from Red Hat, I would love to be able to refer to
> our downstream bugs right in the enter_bug.cgi.

Comment 3

[sjw]

Same for the "Depens on" and "Blocks" fields.

Comment 5

[David Lawrence [:dkl]]

Attachment: 513212_1.patch

Comment 6

[Frédéric Buclin]

Comment on attachment 8391534 [details] [diff] [review]
513212_1.patch

>=== modified file 'post_bug.cgi'

>+# Sending emails for any referenced bugs.
>+foreach my $ref_bug_id (uniq @{ $bug->{see_also_changes} || [] }) {
>+    my $ref_sent = Bugzilla::BugMail::Send($ref_bug_id, $recipients);

Err.... since when is it the job of the caller to send bugmails? If that was true, then process_bug.cgi would have similar code. The code sending these bugmails is in Bugzilla::Bug already.

Comment 7

[David Lawrence [:dkl]]

Attachment: 513212_2.patch

Originally was coding similar to what was already in post_bug.cgi but as LpSolit pointed out, using $bug->send_changes() will work in the context of Bug.create but not post_bug.cgi unfortunately.

dkl

Comment 8

[:glob ✱]

Comment on attachment 8391948 [details] [diff] [review]
513212_2.patch

Review of attachment 8391948 [details] [diff] [review]:
-----------------------------------------------------------------

i'm happy with the code changes here, however the UI on create-bug looks weird.
(add) has an extra line before it (appears to be an errant <ul>).
it should look the same as it does on show_bug.

::: Bugzilla/Bug.pm
@@ +726,5 @@
> +        foreach my $value (@$see_also_array) {
> +            $bug->add_see_also($value);
> +        }
> +        $_->insert_create_data($_) foreach @{ $bug->see_also };
> +        $_->update foreach @{ $bug->{_update_ref_bugs} || [] };

for clarity i would prefer a more verbose foreach here, with a named loop variable instead of $_

Comment 9

[David Lawrence [:dkl]]

Attachment: 513212_3.patch

Thanks for the review. New patch.

Comment 10

[:glob ✱]

Comment on attachment 8393727 [details] [diff] [review]
513212_3.patch

Review of attachment 8393727 [details] [diff] [review]:
-----------------------------------------------------------------

the enter_bug ui is now missing the whitespace, however the bold "add bug urls:" looks very out of place on enter_bug.  it looks ok-ish on show_bug, but still weird imho.

i think it would be better overall to remove that <strong> tag completely, and instead use a placeholder of "Bug URLs".

another possibility is to remove that <strong> text completely on both enter_bug and show_bug.  no other fields in bugzilla display instructional text when you try to set it.

Comment 11

[David Lawrence [:dkl]]

Attachment: 513212_4.patch

I vote for removing the <strong> text completely as well and does look cleaner in both enter_bug.cgi and show_bug.cgi now.

dkl

Comment 12

[:glob ✱]

Comment on attachment 8394176 [details] [diff] [review]
513212_4.patch

r=glob with the following change to be made prior to committing:

there's a margin below the list of linked bugs on show_bug; can you please update .bug_urls to set the margin to 0px.

Comment 13

[David Lawrence [:dkl]]

Counting objects: 35, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (16/16), done.
Writing objects: 100% (18/18), 2.01 KiB, done.
Total 18 (delta 15), reused 0 (delta 0)
To ssh://[e-mail]/bugzilla/bugzilla.git
   ca7b39a..9f18c2a  master -> master