Closed
Bug 513277
Opened 16 years ago
Closed 16 years ago
Grouped search terms fail due to error in set/get beginsgrouping
Categories
(MailNews Core :: Search, defect)
MailNews Core
Search
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b4
People
(Reporter: rkent, Assigned: rkent)
References
Details
Attachments
(1 file)
|
7.03 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
While preparing for implementing bug 505307, I wrote a unit test of grouped search terms to convince myself that I understood how to use them. But I could not make the test work. Digging in, I found this code http://hg.mozilla.org/comm-central/annotate/e392c93ea182/mailnews/base/search/src/nsMsgSearchTerm.cpp#l1775 that is clearly wrong:
NS_IMPL_GETSET(nsMsgSearchTerm, BeginsGrouping, PRBool, mEndsGrouping)
NS_IMPL_GETSET(nsMsgSearchTerm, EndsGrouping, PRBool, mEndsGrouping)
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #397365 -
Flags: superreview?(bienvenu)
Attachment #397365 -
Flags: review?(bienvenu)
|
|
Assignee | |
Comment 2•16 years ago
|
||
Since it blocks a blocker, should be a blocker right? Sorta moot though except to get attention. Possibly fixes bug 479045 though I did not test that.
Flags: blocking-thunderbird3?
Whiteboard: [needs r/sr bienvenu]
Target Milestone: --- → Thunderbird 3.0b4
|
||
Comment 3•16 years ago
|
||
Comment on attachment 397365 [details] [diff] [review]
One-line fix of begins grouping getset, plus unit test.
thx, Kent.
Attachment #397365 -
Flags: superreview?(bienvenu)
Attachment #397365 -
Flags: superreview+
Attachment #397365 -
Flags: review?(bienvenu)
Attachment #397365 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [needs r/sr bienvenu] → [needs checkin]
|
|
||
Comment 4•16 years ago
|
||
fix checked in - marking blocker since it blocks a blocking bug.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [needs checkin]
You need to log in
before you can comment on or make changes to this bug.
Description
•