479045 - quick search and view don't work for saved search

Status: RESOLVED WORKSFORME

(Thunderbird :: Search, defect)

Description

[Wayne Mery (:wsmwk)]

+++ This bug was initially created as a clone of Bug #472988 +++

patch in Bug 472988 breaks both quick search and view for saved search

is there a trivial solution? or is backout and reopen of Bug 472988 needed? 
(wouldn't want this regression to go into beta 2)

Comment 1

[David :Bienvenu]

I'll look - is there anything on the error console when this happens? I suspect there's some confusion about the view that's causing the issue...

Comment 2

[Wayne Mery (:wsmwk)]

no, nothing in console

Comment 3

[David :Bienvenu]

this works for me - what kind of saved search is it? single folder or cross-folders? Do you have multiple tabs opened?

Comment 4

[David :Bienvenu]

oh, you might try running the javascript debugger when this happens, if you have it. Someone is catching and swallowing exceptions in this code, which I discovered when doing bug 472988...

Comment 5

[Wayne Mery (:wsmwk)]

bah. now I can't reproduce.

The saved search called "Firefox" was multiple folder, using custom header x-mozilla-product set to match Firefox.

steps were approximately
1. start build 20090218
2. login master and account password
3. click inbox
4. right click saved search "Firefox" and open in new tab
5. select view=unread
results: nothing displayed

6. view=all
7. enter text in quicksearch
results: nothing displayed

sounds ridiculous, but maybe in only happens upon first entry.
removing blocking request since I can't reproduce now, on 2 systems.
doubt I'll be able to spend further time on this today

Comment 6

[Wayne Mery (:wsmwk)]

FWIW I came from Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090213 Shredder/3.0b2pre

you might also try combinations of moving between saved and non-saved folders when tabbed, and then same after closing the plain folder's tab - some change combinations are wonky but might be an already reported bug.

Comment 7

[Jeff Bastian]

I've recently started seeing this on Thunderbird 3.0b3 on Fedora 11 
  thunderbird-3.0-2.6.b3.fc11.i586

I have a Saved Search folder to show me messages in my Inbox from various bugzillas ([e-mail], [e-mail], [e-mail], etc).  If I click on this Bugzilla Saved Search folder and then use the QuickSearch to filter it down even more to emails about a specific bug,  Thunderbird will show me the matching emails plus more that don't match.

For example, let's say I have 5 emails in the Bugzilla Saved Search folder:
  Subject: foo        (read)
  Subject: bar        (unread)
  Subject: baz        (read)
  Subject: qwerty     (read)
  Subject: asdf       (unread)

I enter "bar" in the QuickSearch to see just the 1 email about "bar", but Thunderbird shows me
  Subject: foo
  Subject: bar
  Subject: qwerty

Then, I clear the QuickSearch and then try "View: Unread" and it shows me
  Subject: bar        (unread)
  Subject: baz        (read)
  Subject: asdf       (unread)

In both cases, it shows me the matching messages plus some more, but it does filter out some of the emails.

If I go to the plain Inbox (not a Saved Search folder) and try the QuickSearch or View Unread, it works as expected.

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

What type of account is it?  If it is IMAP, are all of the folders involved marked for offline use?

What is the value of "terms" from virtualFolders.dat in your profile directory for the saved search?

Comment 9

[Jeff Bastian]

It is IMAP, and the folders are synced for offline use (although I never actually use it offline...)

terms=OR (from,contains,[e-mail]) OR (from,contains,[e-mail]) OR (from,contains,[e-mail]) OR (from,contains,[e-mail])

Comment 10

[Jeff Bastian]

I just disabled offline usage and enabled the Search Online checkbox for the virtual folders and now I'm getting accurate search results with QuickSearch.

Comment 11

[Jeff Bastian]

I spoke too soon: I get accurate QuickSearch results if I use just 'Subject' in the QuickSearch, but if I change it to 'Subject or From' it shows nothing at all on my searches.

Comment 12

[Jeff Bastian]

This may be a different bug, but I also noticed that while looking at the filtered list from a QuickSearch, if a new email arrives, it's displayed even if it doesn't match the QuickSearch.

For example, QuickSearch on Subject for "foo" shows:
  Subject: foo
  Subject: Re: foo

Then a new email arrives and it shows:
  Subject: foo
  Subject: Re: foo
  Subject: bar

Thunderbird 2.x would not show the new email if it did not match.

Comment 13

[Wayne Mery (:wsmwk)]

(In reply to comment #12)
> This may be a different bug, but I also noticed that while looking at the
> filtered list from a QuickSearch, if a new email arrives, it's displayed even
> if it doesn't match the QuickSearch.

I can't reproduce that idea with 20090824 Shredder/3.0b4pre. In any case, it would be a separate bug

Comment 14

[Kent James (:rkent)]

I suspect this is bug 513277.

Comment 15

[Wayne Mery (:wsmwk)]

Jeff, I can't reproduce any more - can you?

Comment 16

[Jeff Bastian]

It works for me also using Thunderbird 3.1.7 on Fedora 14.