Closed Bug 513653 Opened 10 years ago Closed 10 years ago

Fix switching to an existing tab when trying to open a content tab with the same url

Categories

(Thunderbird :: Toolbars and Tabs, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b4

People

(Reporter: standard8, Assigned: standard8)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Attached patch The fix (obsolete) — Splinter Review
We previously had functionality to switch to an exist tab rather than open a new one if there was one with the same url alredy open. At some stage recently I broke that.

Attached patch fixes it and also removes a redundant type setting as we're trying to set type=content-primary on a vbox. Other code in the contentTabType does it correctly on the browser element.
Flags: in-testsuite?
Attachment #397594 - Flags: review?(bugmail)
Oh, btw I have mozmill tests that I'm writing for content tabs, but they need a bit more work yet before I'm ready to submit. They do already cover this bug (hence in-testsuite?).
Attachment #397594 - Flags: review?(bugmail) → review+
Attached patch The fix v2Splinter Review
I thought removing that line about content-primary was useful, what I didn't realise was that I had also broken window.content for new content tabs by not setting content-primary on the browser element when creating the tab (the browser we clone uses content-targetable).

This patch fixes that and adds the first part of the content tab tests which tests this bug is fixed. Although there's more cases, I'll be adding to those as we go.
Attachment #397594 - Attachment is obsolete: true
Attachment #397869 - Flags: review?(bugmail)
Comment on attachment 397869 [details] [diff] [review]
The fix v2

Hopefully the test machines are okay with the choice of sleep constant.
Attachment #397869 - Flags: review?(bugmail) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/014559d2105b

(In reply to comment #3)
> (From update of attachment 397869 [details] [diff] [review])
> Hopefully the test machines are okay with the choice of sleep constant.

Yeah, hopefully, we'll see how it goes.
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.