Closed Bug 513777 Opened 15 years ago Closed 15 years ago

nsChildView.mm does not compile 64-bit, lacking ifdefs and other fixes

Categories

(Core :: Widget: Cocoa, defect)

x86_64
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(3 files, 1 obsolete file)

nsChildView.mm does not compile 64-bit, lacking ifdefs and other fixes.
Attached patch part 1, v1.0 (obsolete) — Splinter Review
Attachment #397717 - Flags: review?(smichaud)
Attached patch part 1, v1.1Splinter Review
Forgot to updated a comment.
Attachment #397717 - Attachment is obsolete: true
Attachment #397719 - Flags: review?(smichaud)
Attachment #397717 - Flags: review?(smichaud)
Attachment #397719 - Flags: review?(smichaud) → review?(mstange)
Attachment #397719 - Flags: review?(mstange) → review+
pushed part 1 to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/a3f91fac11aa
Attached patch part 2, v1.0Splinter Review
pushed part 2 to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/e4e5cce8e7e0
Depends on: 518542
Attached patch part 3, v1.0Splinter Review
final patch
Attachment #403950 - Flags: review?(mstange)
Attachment #403950 - Flags: review?(mstange) → review+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/1b66f53dcbdf

this resolves this bug
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
(In reply to comment #7)
> pushed to mozilla-central
> 
> http://hg.mozilla.org/mozilla-central/rev/1b66f53dcbdf
> 
> this resolves this bug

josh:

Looks like you can remove mPluginTSMDoc definition in nsChildView.h by the ifdef.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: