518542 - Two-finger scrolling does not work on Snow Leopard

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Joel Reymont (:joelr)]

Works fine in the 32-bit build.

Comment 1

[Markus Stange [:mstange]]

That's because Josh has just ifdef'd out all the scrolling code.

Comment 2

[Joel Reymont (:joelr)]

Josh, what's the problem with scrolling?

Comment 3

[Josh Aas]

I forgot to file this bug when I landed the patch. See our implementation of:

-(void)scrollWheel:(NSEvent*)theEvent forAxis:(enum nsMouseScrollEvent::nsMouseScrollFlags)inAxis

which right now is at:

http://mxr.mozilla.org/mozilla-central/source/widget/src/cocoa/nsChildView.mm#3546

It uses APIs that are not available to 64-bit applications.

Comment 4

[Markus Stange [:mstange]]

Which APIs are that? Anything other than the Carbon plugin events?

Comment 5

[Josh Aas]

I don't remember, whoever ends up working on this will have to look at the code.

Comment 6

[Joel Reymont (:joelr)]

Is inheriting from NSScrollView an option here: 

http://mxr.mozilla.org/mozilla-central/source/widget/src/cocoa/nsChildView.h#118

We could then piggyback on the standard Cocoa scrolling APIs:

http://developer.apple.com/mac/library/documentation/Cocoa/Conceptual/NSScrollViewGuide/Articles/Scrolling.html#//apple_ref/doc/uid/TP40003463-SW3

It may be possible to do this without NSScrollView but I need to run some tests.

Comment 7

[Markus Stange [:mstange]]

No, that's not an option. One reason is that not all Gecko scrollboxes have their own NSView; another reason is that we need to send mouse wheel events so that websites can process them and do other things than scrolling (e.g. zooming on Google Maps).

Comment 8

[Joel Reymont (:joelr)]

It seems that the only option is to piggyback on mouse dragging:

http://developer.apple.com/mac/library/documentation/Cocoa/Conceptual/EventOverview/HandlingMouseEvents/HandlingMouseEvents.html

If not all scrollboxes have their their own NSView then either we'll need to work with the parent NSView or we are screwed.

Comment 9

[Markus Stange [:mstange]]

What do you mean with mouse dragging? Two finger scrolling works via the NSResponder method -(void)scrollWheel:(NSEvent*)theEvent that josh pointed to. We don't need an NSScrollView to receive those events.

Comment 10

[Joel Reymont (:joelr)]

Attachment: Scrolling works, no carbon events

Comment 11

[Josh Aas]

Attachment: fix v1.1

There were some other things bothering me here. I fixed them in this patch and I filed bug 519100 about providing scroll wheel events to Cocoa NPAPI plugins.

Comment 12

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/48ed3509beaf