Closed
Bug 513972
Opened 15 years ago
Closed 15 years ago
tweak default number of autocomplete results to speed up awesomebar appearance
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
fennec1.0b4
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
Attachments
(1 file)
|
3.05 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Right now we have 7 entries by default, while the maximum number of entries we'll show is 12 (for a user with a relatively full history).
Adding more elements by default means we'll have fewer elements to create dynamically when we're showing the popup, in the maximum-results case (common case for first open after moderate use).
If we can do this without impacting Ts too much, I think it's worth it.
|
Assignee | |
Comment 1•15 years ago
|
||
The maxEntries thing is unneeded, since the backend already limits the number of results based on the maxRichResults pref.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•15 years ago
|
||
I'll get measurements to see how much this improves first-open time, but I'm not sure I'll be able to get reliable Ts numbers.
|
|
Assignee | |
Comment 3•15 years ago
|
||
The popup-filling code seems to take about 45ms on average with the patch, while it takes about 70ms without it.
|
|
Assignee | |
Updated•15 years ago
|
Attachment #397913 -
Flags: review?(mark.finkle)
|
||
Updated•15 years ago
|
Attachment #397913 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
https://hg.mozilla.org/mobile-browser/rev/3e29321d92b9
will keep an eye on Ts...
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → B4
|
||
Comment 5•15 years ago
|
||
appears to be making a difference.
verified on my n810 with 20090921 1.9.2 nightly build
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•